From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwQ3Y-0001Rf-Ty for guix-patches@gnu.org; Mon, 25 Sep 2017 05:52:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwQ3W-0005nL-8I for guix-patches@gnu.org; Mon, 25 Sep 2017 05:52:04 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48608) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dwQ3W-0005nG-45 for guix-patches@gnu.org; Mon, 25 Sep 2017 05:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dwQ3V-0004uw-RG for guix-patches@gnu.org; Mon, 25 Sep 2017 05:52:01 -0400 Subject: [bug#28531] [PATCH] gnu: Add vcsh. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <150593626773.31985.7642001649222018304.stgit@sandburg> <87a81pru0m.fsf@gnu.org> <87o9q2o1bw.fsf@xsteve.at> <87vak9a875.fsf@gnu.org> <87vak92sm2.fsf@xsteve.at> Date: Mon, 25 Sep 2017 11:50:55 +0200 In-Reply-To: <87vak92sm2.fsf@xsteve.at> ("Stefan \=\?utf-8\?Q\?Reich\=C3\=B6r\=22\?\= \=\?utf-8\?Q\?'s\?\= message of "Sat, 23 Sep 2017 20:10:45 +0200") Message-ID: <8760c7ksxs.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Stefan =?UTF-8?Q?Reich=C3=B6r?= Cc: 28531@debbugs.gnu.org Hi, Stefan Reich=C3=B6r skribis: > Thanks for the explaination. I see the benefit of the static binding. > The good thing is that the package versions are reproducable. > However, I am used to the way it works on other systems. There is almost > always the search path used to start other programs. > > And to make it even more complicated, I still use Ubuntu and install > some tools using Guix. So it is even possible that I use vcsh from Guix > and git from Ubuntu. Indeed. From a reproducibility viewpoint, it=E2=80=99s something we=E2=80= =99d like to avoid, because then vcsh might behave completely differently depending on what the underlying distro is, and that=E2=80=99s clearly not what we ex= pect from Guix. > I took a look at the vcsh script. git is hardcoded in many places there. > Patching it to have static binding seems to be complicated. The only > sane solution would be to change the script and make git configurable > and try to make this change upstream. However I am not really keen on > doing this kind of work... > > Or do you have another idea how the static binding should be accomplished? I think it might be enough to do a regexp substitution matching all =E2=80=9Cgit=E2=80=9D commands in the script: (substitute* "vcsh" (("\\