From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxJ1y-0006aR-5g for guix-patches@gnu.org; Wed, 27 Sep 2017 16:34:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxJ1u-0007zO-7P for guix-patches@gnu.org; Wed, 27 Sep 2017 16:34:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55010) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxJ1u-0007zK-46 for guix-patches@gnu.org; Wed, 27 Sep 2017 16:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dxJ1t-0001cR-RN for guix-patches@gnu.org; Wed, 27 Sep 2017 16:34:01 -0400 Subject: [bug#28487] [PATCH] cuirass: Add gnu-system build spec. Resent-Message-ID: From: Jan Nieuwenhuizen References: <20170917201157.9802-1-janneke@gnu.org> <20170917201157.9802-5-janneke@gnu.org> <87zi9h27q3.fsf@gnu.org> <87mv5hqr73.fsf@gnu.org> <87a81hgq5g.fsf@gnu.org> <87a81gq8dg.fsf@gnu.org> <87efqsexi4.fsf@gnu.org> Date: Wed, 27 Sep 2017 22:32:32 +0200 In-Reply-To: <87efqsexi4.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 27 Sep 2017 21:45:39 +0200") Message-ID: <8760c3rifz.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Ricardo Wurmus , 28487@debbugs.gnu.org Ludovic Court=C3=A8s writes: >> Anyway, what I proposed was close and attached is a tested, working >> version (that may need some work, see below). > > Oh good points, thanks for testing! np...as I'm using this myself it's nice if it works ;-) > BTW, there=E2=80=99s =E2=80=9Cmake hydra-jobs.scm=E2=80=9D, which I occas= ionally use to test > gnu-system.scm (it spits a raw alist, which is enough to make sure that > it works.) We could similarly add =E2=80=9Cmake cuirass-jobs.scm=E2=80= =9D eventually. ...looked into this briefly but this would mean adding some option to evaluate.scm, something like ;; Without further ado... (match (command-line) - ((command file) + ((command file cuirass? ...)) ... - (match ((module-ref %user-module 'hydra-jobs) store '()) + (match ((module-ref %user-module + (if (equal? cuirass? "cuirass") cuirass-jobs 'hydra-jobs) ? store '()) > Yes, separate patch for clarity: first patch does the Hydra/Cuirass > split, second patch adds the ability to select a list of packages. > > Would that be OK? Sure, done. >> + #:export ( > > I prefer not to export record type descriptors in general, because that > exposes too much of the internals Sure, I agree. Using license? and accessors now. As an aside: Interesting, I've been using GOOPS a lot with match and we have standardised on only matching class/record type, like so (match o (($ ) ...) so I was wondering why you didn't export . Now it makes sense: you simply cannot use record destructors if you don't export <..> in the first place. For GOOPS that's a bit different, you don't have class? for each . > Anyway, with this fixed, OK to push. Thanks, pushed with all this fixed to master as 516b53828e90018126b79e7600c= ae9aa531e06d7 > After that we should update the config on berlin.guixsd.org to use this > file directly. Ricardo: ping? > Thanks a lot! Thank you! Most welcome, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com