From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eGgrD-0000RF-BS for guix-patches@gnu.org; Mon, 20 Nov 2017 02:51:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eGgr8-0000Kk-HA for guix-patches@gnu.org; Mon, 20 Nov 2017 02:51:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:39520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eGgr8-0000KR-Ct for guix-patches@gnu.org; Mon, 20 Nov 2017 02:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eGgr8-0001vh-6F for guix-patches@gnu.org; Mon, 20 Nov 2017 02:51:02 -0500 Subject: [bug#29359] [PATCH 27/31] gnu: Add java-jdom2. Resent-Message-ID: References: <20171119175805.902-1-julien@lepiller.eu> <20171119175805.902-27-julien@lepiller.eu> From: Ricardo Wurmus In-reply-to: <20171119175805.902-27-julien@lepiller.eu> Date: Mon, 20 Nov 2017 08:50:00 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <8760a5xuc7.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 29359@debbugs.gnu.org Hi Julien, > * gnu/packages/java.scm (java-jdom2): New variable. How about adding this to (gnu packages xml) instead? I=E2=80=99d like to prevent java.scm from becoming the next python.scm=E2=80=A6 > +(define-public java-jdom2 Why name it =E2=80=9Cjava-jdom2=E2=80=9D? I=E2=80=99d prefer just =E2=80= =9Cjava-jdom=E2=80=9D. > + (description "Java-based solution for accessing, manipulating, and > +outputting XML data from Java code.") Please use a full sentence here. > + (license license:bsd-4))) This seems to be correct. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net