From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49336)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eUcUL-0005iP-Rg
	for guix-patches@gnu.org; Thu, 28 Dec 2017 13:01:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eUcUI-0001Jv-Th
	for guix-patches@gnu.org; Thu, 28 Dec 2017 13:01:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:46746)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eUcUI-0001Ib-Ka
	for guix-patches@gnu.org; Thu, 28 Dec 2017 13:01:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eUcUI-0004LK-8C
	for guix-patches@gnu.org; Thu, 28 Dec 2017 13:01:02 -0500
Subject: [bug#29678] [PATCH] gnu: qemu: Add pulseaudio support.
Resent-Message-ID: <handler.29678.B29678.151448405616675@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <87o9n3kgez.fsf@gmail.com>
References: <87o9n3kgez.fsf@gmail.com>
Date: Thu, 28 Dec 2017 19:00:51 +0100
Message-ID: <87608qd964.fsf@fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>, 29678@debbugs.gnu.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Oleg Pykhalov <go.wigust@gmail.com> writes:

> From 2eff4caca543d9909758a4f2eb6f953467a309d7 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Fri, 8 Dec 2017 18:51:10 +0300
> Subject: [PATCH] gnu: qemu: Add pulseaudio support.
>
> * gnu/packages/virtualization.scm (qemu): Add pulseaudio support.

Please mention the change to [inputs] and [arguments] here.

[...]

> @@ -98,7 +99,11 @@
>       '(;; Running tests in parallel can occasionally lead to failures, l=
ike:
>         ;; boot_sector_test: assertion failed (signature =3D=3D SIGNATURE=
): (0x00000000 =3D=3D 0x0000dead)
>         #:parallel-tests? #f
> -       #:configure-flags '("--enable-usb-redir" "--enable-opengl")
> +       #:configure-flags
> +       (list "--enable-usb-redir"
> +             "--enable-opengl"
> +             (string-append "--audio-drv-list=3D"
> +                            (string-join (list "alsa" "pa" "sdl") ",")))

OK!

>         #:phases
>         (modify-phases %standard-phases
>           (replace 'configure
> @@ -166,6 +171,7 @@
>         ("ncurses" ,ncurses)
>         ;; ("pciutils" ,pciutils)
>         ("pixman" ,pixman)
> +       ("pulseaudio" ,pulseaudio)

I see pulseaudio is already in Qemus closure, so this does not add
anything.  LGTM!

>         ("sdl" ,sdl)
>         ("spice" ,spice)
>         ("usbredir" ,usbredir)
> --=20
> 2.15.1

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlpFMVMACgkQoqBt8qM6
VPqPNAgAwrEzvVA3v1nmZ9sWtYKCg+9phcpHi+9gSplzZLoiXBHerVkGGHIz/CIX
OYBqELG8wfrFE+8idGfvAt8DsNWoTlGYhlXyrHQyEUfd2S78yfp5M6AR4AeyPWzb
FSHchkAjYraEfJiaJzE21LcOOPaPAYS6BXo5ox3isqava+GQnpF86D653SbgHzD7
sfE2EmnizxF+Sm5G94qH9Dd8xOljgPNWDj8KBd93QoMwX7/Zpy6GhYCbnXwazF7T
TxiNpIiuYLhsnehfz+UXiS40q4eItpFF10zKPyUjqppsvDfIT/6YEGI31b7Bg/7I
XSHtwKd9uAlVGzk4FR5mx9lropMkJg==
=H087
-----END PGP SIGNATURE-----
--=-=-=--