From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elwtu-0006nL-JP for guix-patches@gnu.org; Wed, 14 Feb 2018 08:15:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elwtr-0001By-HH for guix-patches@gnu.org; Wed, 14 Feb 2018 08:15:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:34341) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elwtr-0001Bh-Dn for guix-patches@gnu.org; Wed, 14 Feb 2018 08:15:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1elwtr-0004bK-8L for guix-patches@gnu.org; Wed, 14 Feb 2018 08:15:03 -0500 Subject: bug#30333: [PATCH] gnu: Add emacs-scratch-el. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Oleg Pykhalov References: <20180203104703.16476-1-go.wigust@gmail.com> <87po58wl3q.fsf@fastmail.com> Date: Wed, 14 Feb 2018 16:00:29 +0300 In-Reply-To: <87po58wl3q.fsf@fastmail.com> (Marius Bakke's message of "Wed, 14 Feb 2018 00:00:57 +0100") Message-ID: <87606ziv4i.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 30333@debbugs.gnu.org, 30333-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Marius Bakke writes: > Oleg Pykhalov writes: > >> * gnu/packages/emacs.scm (emacs-scratch-el): New public variable. > > [...] > >> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm >> index 9523f14da..69d18b060 100644 >> --- a/gnu/packages/emacs.scm >> +++ b/gnu/packages/emacs.scm >> @@ -6940,3 +6940,41 @@ navigation with the grails mode.") >> @code{org-tree-slide-mode} to enter the slideshow mode, and then @kbd{C->} and >> @kbd{C-<} to jump to the next and previous slide.") >> (license license:gpl3+)))) >> + >> +(define-public emacs-scratch-el >> + (let ((commit "2cdf2b841ce7a0987093f65b0cc431947549f897") >> + (revision "1")) >> + (package >> + (name "emacs-scratch-el") >> + (version (string-append "1.2" revision "." >> + (string-take commit 7))) > > You can use (git-version "1.2" revision commit) here. OK. > (by the way, where does 1.2 come from?) https://github.com/ieure/scratch-el/blob/master/scratch.el#L4 >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/ieure/scratch-el.git") >> + (commit commit))) >> + (file-name (string-append name "-" version "-checkout")) > > Similarly, prefer (git-file-name ...). OK. >> + (sha256 >> + (base32 >> + "0wscsndynjmnliajqaz28r1ww81j8wh84zwaaswx51abhwgl0idf")))) >> + (build-system emacs-build-system) >> + (native-inputs >> + `(("texinfo" ,texinfo))) >> + (arguments >> + '(#:phases >> + (modify-phases %standard-phases >> + (add-after 'install 'install-doc >> + (lambda* (#:key outputs #:allow-other-keys) >> + (unless (invoke "makeinfo" "scratch.texi") >> + (error "makeinfo failed")) >> + (install-file "scratch.info" >> + (string-append (assoc-ref outputs "out") >> + "/share/info"))))))) > > (install-file ...) has an unspecified return value, so return #t here. OK. >> + (home-page "https://github.com/ieure/scratch-el/") >> + (synopsis "Create scratch buffers with the same mode current buffer") > > s/same mode/same mode as/ OK. > Other than that LGTM. Pushed as ac07b94ab53fb13bb56ea876a5143985e6dfaf11 I'll close the bug report. Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlqEMu0ACgkQckbhHGm3 lWniHw/+PqlogP+8lXiW9Hv2rEE2cw98N2N9cdQKJK5BLtQxYYBp3gVpB9vQkGt6 F0mKNMRSevjNIyIAtkuheKMl1KXN9iWInD7Kb8T5GFv9wiQqwFdQTZvaD55K//f5 OVVM1WPGuSUAU9wpRc9Uoo572co8nXo/ERXkra5N89Z3Ow68B8ep6qK/oza1jI3p aBYWoyNWGsRNvOoJI3I70EMikWVGXngrycE2C77LsSphklvABHxjJktZqXoicY0A qpx+0KICZ4+C+uWndYMA1kV2avbBrHroYW0PdFIs9WhNugxoqqZJwE5k2cd0G0/n OMBFJ9Ml/95GwKkT8C528zoYSCNhm/finrBUhozgMc7pzalYLFhz+Pi6BMP4pfm0 1eGdKNxqo2fVeZgnJ1yRqiqWJGai7KuiKOf/gL2n05xDgG5i8O4RchEU8pjrptHB dmKV4JDJHgHUVMazzzHwpWC6QqZn7mbHPMkD0h6b6mdT0FTy80fqFjcRrr3WsSnj MMPxXEf5miFga128oJ2Nfep+FzBXuKzLVJ1LQKrB7hDURQrtxKk0tOmXkFrNQyY/ lqVr2ecDtkPsiqRkwPvOYJmX8730kRdX0G6SVlTST/Yr5KQ69m9jm5ZlfiTmkC0T ZLDtS85TuLD/McnbMEKLHEXp30ImN6gjw0CwHBtH2wDOKD1ioas= =2aSO -----END PGP SIGNATURE----- --=-=-=--