[bug#30968] [PATCH] gnu: mu: Fix tests failures triggered by DST.

[bug#30968] [PATCH] gnu: mu: Fix tests failures triggered by DST.

[Maxim Cournoyer]

[-- Attachment #1: Type: text/plain, Size: 69 bytes --]

Hello!

This fixes test failures for our mu package.

Thanks!

Maxim

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-mu-Fix-tests-failures-triggered-by-DST.patch --]
[-- Type: text/x-patch, Size: 1252 bytes --]

From b6c27eab14b678d12dd4b3b480ea88542bf096e7 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Tue, 27 Mar 2018 21:59:24 -0400
Subject: [PATCH] gnu: mu: Fix tests failures triggered by DST.

* gnu/packages/mail.scm (mu)[phases]: Add 'fix-date-tests.
---
 gnu/packages/mail.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 4e273a0da..96b53c5bd 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -618,6 +618,13 @@ security functionality including PGP, S/MIME, SSH, and SSL.")
                             "guile/mu/Makefile.in")
                (("share/guile/site/2.0/") "share/guile/site/2.2/"))
              #t))
+         (add-after 'patch-configure 'fix-date-tests
+           ;; Loosen test tolerances to prevent failures caused by daylight
+           ;; time saving (DST).  See: https://github.com/djcb/mu/issues/1214.
+           (lambda _
+             (substitute* "lib/parser/test-utils.cc"
+               (("\\* 60 \\* 60, 1 },")
+                "* 60 * 60, 3600 + 1 },"))))
          (add-before 'install 'fix-ffi
            (lambda* (#:key outputs #:allow-other-keys)
              (substitute* "guile/mu.scm"
-- 
2.16.1

bug#30968: [PATCH] gnu: mu: Fix tests failures triggered by DST.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> From b6c27eab14b678d12dd4b3b480ea88542bf096e7 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Tue, 27 Mar 2018 21:59:24 -0400
> Subject: [PATCH] gnu: mu: Fix tests failures triggered by DST.
>
> * gnu/packages/mail.scm (mu)[phases]: Add 'fix-date-tests.

Well done!  Applied with the minor changes below.

Thank you,

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 907 bytes --]

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index dca4ffb9a..3dab1325e 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -620,11 +620,12 @@ security functionality including PGP, S/MIME, SSH, and SSL.")
              #t))
          (add-after 'patch-configure 'fix-date-tests
            ;; Loosen test tolerances to prevent failures caused by daylight
-           ;; time saving (DST).  See: https://github.com/djcb/mu/issues/1214.
+           ;; saving time (DST).  See: https://github.com/djcb/mu/issues/1214.
            (lambda _
              (substitute* "lib/parser/test-utils.cc"
                (("\\* 60 \\* 60, 1 },")
-                "* 60 * 60, 3600 + 1 },"))))
+                "* 60 * 60, 3600 + 1 },"))
+             #t))
          (add-before 'install 'fix-ffi
            (lambda* (#:key outputs #:allow-other-keys)
              (substitute* "guile/mu.scm"

[bug#30968] [PATCH] gnu: mu: Fix tests failures triggered by DST.

[Maxim Cournoyer]

Hi Ludovic,

ludo@gnu.org (Ludovic Courtès) writes:

> Hi,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> From b6c27eab14b678d12dd4b3b480ea88542bf096e7 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> Date: Tue, 27 Mar 2018 21:59:24 -0400
>> Subject: [PATCH] gnu: mu: Fix tests failures triggered by DST.
>>
>> * gnu/packages/mail.scm (mu)[phases]: Add 'fix-date-tests.
>
> Well done!  Applied with the minor changes below.

Thanks :). I keep overlooking this #t or #f return value.

Maxim