From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fL2Wd-0005cA-UZ for guix-patches@gnu.org; Tue, 22 May 2018 04:20:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fL2WY-00070J-CD for guix-patches@gnu.org; Tue, 22 May 2018 04:20:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:35674) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fL2WY-000709-8C for guix-patches@gnu.org; Tue, 22 May 2018 04:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fL2WY-0001ZS-3k for guix-patches@gnu.org; Tue, 22 May 2018 04:20:02 -0400 Subject: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable. Resent-Message-ID: References: <20180518184910.9987-1-ambrevar@gmail.com> <20180518184910.9987-2-ambrevar@gmail.com> <87zi0soj8t.fsf@elephly.net> From: Pierre Neidhardt In-reply-to: <87zi0soj8t.fsf@elephly.net> Date: Tue, 22 May 2018 10:19:33 +0200 Message-ID: <87603g3xwq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 31499@debbugs.gnu.org --=-=-= Content-Type: text/plain Ricardo Wurmus writes: >> + (uri (string-append "https://github.com/cbowdon/daemons.el/archive/" >> + version ".tar.gz")) > > Please do not use these auto-generated tarballs from GitHub, as they are > generated upon demand. This means that at some point in the future the > hash may change. OK, but I have a few question: - Why would the hash change? If the version tag is not changed (and it's not meant to) the archive remains the same, doesn't it? Besides many Emacs packages use the "/archive" URLs, such as `emacs-emms-player-mpv`. - Do you know the difference between "/archive and "/releases/download"? For instance, Magit uses "https://github.com/magit/magit/releases/download/". That said, I have no issue with using git-fetch instead. I'll submit a patch just now. -- Pierre Neidhardt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlsD0pUACgkQm9z0l6S7 zH8/+Af9FlxWM6DMIiqHBDdm9qX3xOB558m484Kbk7byFcnsOxrt9DEioiH+bPEW X/yw4mIiCT6tUbdXAoJIW98jhfh7QnIiL4Z008ei4Q2iSkJTU2h09EjQnMGGEY0r 2FFXL7dcYO8CqaihNRsEqpiJjQxA9Yj24RkVCV+TnVU6lm3fJps08GS9Uu5NILmm M5uWl7g64uIq28UUX6YppQgFBDGb4vSOSa5wlqw6VzXVZoJOouB71L5/p6B2d4lI 7PhLK2uckQYsfRrxELwdFJVTwpx6BqMNUnpNtjRjC7tAmYJFJfz55b1+TAkqtxh+ 5ZxU0djE4smjgDVuMmzgCJGil+oZuw== =U0m/ -----END PGP SIGNATURE----- --=-=-=--