From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMvRu-0008Uz-OR for guix-patches@gnu.org; Sun, 27 May 2018 09:11:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMvRt-0004bA-Rn for guix-patches@gnu.org; Sun, 27 May 2018 09:11:02 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:42331) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fMvRt-0004ay-Nm for guix-patches@gnu.org; Sun, 27 May 2018 09:11:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fMvRt-0003X7-Ih for guix-patches@gnu.org; Sun, 27 May 2018 09:11:01 -0400 Subject: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180518191247.18456-1-dannym@scratchpost.org> <878t861df7.fsf@gnu.org> <20180526211604.72c336bf@scratchpost.org> Date: Sun, 27 May 2018 15:10:05 +0200 In-Reply-To: <20180526211604.72c336bf@scratchpost.org> (Danny Milosavljevic's message of "Sat, 26 May 2018 21:16:04 +0200") Message-ID: <876039xn0y.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 31520@debbugs.gnu.org Hello Danny! Danny Milosavljevic skribis: > On Sat, 26 May 2018 20:26:20 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > >> Why is it needed? That would need a comment. :-) > > dtc has Python bindings and we build them. But then we do not need a search path definition in dtc itself; the one in Python is enough. Or am I missing something? >> Even better if we >> can achieve the same effect without defining this search path. > > Sure, I guess. If you install dtc into your profile it won't work then t= hough. I think there are two possible situations: 1. dtc provides Python bindings that are useful to Python programmers. This is addressed by having both Python and dtc in the same profile, in which case PYTHONPATH is automatically defined. Nothing special to do. 2. dtc is itself written in Python and needs to access its own Python code. In that case we should wrap the =E2=80=98dtc=E2=80=99 co= mmand such that PYTHONPATH contains the right thing. Does that make sense? > Also, do you think we should try to extract the Python bindings into its = own > package? Not necessarily, it probably doesn=E2=80=99t take up much space. >> > + (add-after 'install 'check >> > + (lambda* (#:key make-flags test-target #:allow-other-key= s) >> > + (apply invoke "make" "mrproper" make-flags) >> > + (setenv "SDL_VIDEODRIVER" "dummy") >> > + (setenv "PAGER" "cat") >> > + (apply invoke "make" test-target make-flags) >> > + (symlink "build-sandbox_spl" "sandbox") >> > + (invoke "test/image/test-imagetools.sh"))))))=20=20 >>=20 >> Please return #t. > > invoke does :) Oh, true, sorry! Thanks, Ludo=E2=80=99.