From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 33267@debbugs.gnu.org
Subject: [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon.
Date: Mon, 05 Nov 2018 00:16:39 -0500 [thread overview]
Message-ID: <875zxc5cjs.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 83 bytes --]
Hi!
The following small issue caught my eye while I was reading the code.
Maxim
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ssh-Honor-the-SOCKET-NAME-argument-of-connect-to-rem.patch --]
[-- Type: text/x-patch, Size: 993 bytes --]
From dd6d3ee8bec3a99fd178a8efddfa417fbed72a66 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Mon, 5 Nov 2018 00:01:47 -0500
Subject: [PATCH] ssh: Honor the SOCKET-NAME argument of
connect-to-remote-daemon.
* guix/ssh.scm (connect-to-remote-daemon): Pass the `socket-name' variable to
the `open-connection' call so that it is honored.
---
guix/ssh.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix/ssh.scm b/guix/ssh.scm
index da20d4d8d..25ec8295e 100644
--- a/guix/ssh.scm
+++ b/guix/ssh.scm
@@ -161,7 +161,7 @@ Throw an error on failure."
"/var/guix/daemon-socket/socket"))
"Connect to the remote build daemon listening on SOCKET-NAME over SESSION,
an SSH session. Return a <nix-server> object."
- (open-connection #:port (remote-daemon-channel session)))
+ (open-connection #:port (remote-daemon-channel session socket-name)))
(define (store-import-channel session)
--
2.19.0
next reply other threads:[~2018-11-05 5:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 5:16 Maxim Cournoyer [this message]
2018-11-05 20:46 ` [bug#33267] [PATCH] ssh: Honor the SOCKET-NAME argument of connect-to-remote-daemon Ludovic Courtès
2018-11-06 2:30 ` Maxim Cournoyer
2018-11-06 2:30 ` bug#33267: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zxc5cjs.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=33267@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).