From: Ricardo Wurmus <rekado@elephly.net>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 34198@debbugs.gnu.org
Subject: [bug#34198] [PATCH 2/2] gnu: Add diffpdf.
Date: Tue, 29 Jan 2019 18:08:45 +0100 [thread overview]
Message-ID: <875zu7pf1e.fsf@elephly.net> (raw)
In-Reply-To: <20190125164802.17853-2-dannym@scratchpost.org>
Hi Danny,
> * gnu/packages/pdf.scm (diffpdf): New variable.
[…]
> + (build-system gnu-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch-paths
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "diffpdf.pro"
> + (("-lpoppler-qt4")
> + (string-append "-L" (assoc-ref inputs "poppler-qt4")
> + "/lib -lpoppler-qt4"))
Is this really necessary? Shouldn’t it be enough to have this directory
on LIBRARY_PATH at build time?
> + (inputs
> + `(("poppler-qt4" ,poppler-qt4) ; at least 0.20.1
> + ("qt-4" ,qt-4)))
I was hoping we could get rid of Qt 4 in the near future, because it
doesn’t get security fixes. Is there no Qt 5 variant?
> + (home-page "http://www.qtrac.eu/diffpdf-foss.html")
> + (synopsis "Compare two PDF files")
> + (description "This package provides a GUI tool to compare two PDF files.")
> + (license license:gpl2)))
Looks like GPLv2 or later.
--
Ricardo
next prev parent reply other threads:[~2019-01-29 17:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 16:43 [bug#34198] [PATCH 0/2] Add diffpdf Danny Milosavljevic
2019-01-25 16:48 ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Danny Milosavljevic
2019-01-25 16:48 ` [bug#34198] [PATCH 2/2] gnu: Add diffpdf Danny Milosavljevic
2019-01-29 17:08 ` Ricardo Wurmus [this message]
2019-01-29 20:12 ` Danny Milosavljevic
2019-01-29 17:05 ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Ricardo Wurmus
2019-01-29 20:09 ` Danny Milosavljevic
2019-01-31 21:59 ` Marius Bakke
2020-09-05 20:47 ` bug#34198: Closing Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zu7pf1e.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=34198@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).