From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:41487)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJH5z-0001nM-Uz
	for guix-patches@gnu.org; Wed, 24 Apr 2019 08:33:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJH2J-0004Jy-Sd
	for guix-patches@gnu.org; Wed, 24 Apr 2019 08:30:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41717)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hJH2J-0004Jq-PV
	for guix-patches@gnu.org; Wed, 24 Apr 2019 08:30:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJH2I-0000iP-0r
	for guix-patches@gnu.org; Wed, 24 Apr 2019 08:30:03 -0400
Subject: [bug#35330] [PATCH] gnu: certbot: Add support for manual plugin.
Resent-Message-ID: <handler.35330.B35330.15561089662685@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190419212320.20256-1-julien@lepiller.eu>
Date: Wed, 24 Apr 2019 14:29:12 +0200
In-Reply-To: <20190419212320.20256-1-julien@lepiller.eu> (Julien Lepiller's
	message of "Fri, 19 Apr 2019 23:23:20 +0200")
Message-ID: <875zr3egdj.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 35330@debbugs.gnu.org

Hello,

Julien Lepiller <julien@lepiller.eu> skribis:

> * gnu/services/certbot.scm (certificate-configuration): Add challenge,
> auth-hook and cleanup-hook fields.
> (certbot-command): Use them.
> * doc/guix.texi (Certificate Services): Document them.

Neat!

Nitpick:

  - s/http/HTTP/
  - two spaces after end-of-sentence period
  - s/filename/file name/

> +@item @code{challenge} (default: @code{#f})
> +The challenge type that has to be run by certbot. If @code{#f} is specif=
ied,
> +default to the http challenge. If a value is specified, defaults to the
> +manual plugin (see @code{auth-hook} and @code{cleanup-hook}).

If there=E2=80=99s a stable URL to upstream documentation, perhaps you could
insert it here.

> +@item @code{auth-hook} (default: @code{#f})

Should it be called =E2=80=98authentication-hook=E2=80=99?

I=E2=80=99m definitely no expert, but I=E2=80=99d say go for it!

Thanks for working on it!

Ludo=E2=80=99.