From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:40036)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMUZg-00016V-5I
 for guix-patches@gnu.org; Mon, 21 Oct 2019 06:06:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMUZf-0002kj-0A
 for guix-patches@gnu.org; Mon, 21 Oct 2019 06:06:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:46920)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iMUZe-0002kX-JE
 for guix-patches@gnu.org; Mon, 21 Oct 2019 06:06:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMUZe-00051v-D2
 for guix-patches@gnu.org; Mon, 21 Oct 2019 06:06:02 -0400
Subject: [bug#37817] [PATCH 1/7] gnu: Add cl-heap.,
 [bug#37817] [PATCH 2/7] gnu: Add curry-compose-reader-macros.,
 [bug#37817] [PATCH 3/7] gnu: Add yason.,
 [bug#37817] [PATCH 4/7] gnu: sbcl-iterate: Add missing native input.,
 [bug#37817] [PATCH 5/7] gnu: Add ecl-iterate.,
 [bug#37817] [PATCH 6/7] gnu: Add stefil.,
 [bug#37817] [PATCH 7/7] gnu: Add graph.
Resent-Message-ID: <handler.37817.B37817.157165233119295@debbugs.gnu.org>
References: <87k191x006.fsf@yamatai> <20191018204206.15154-1-glv@posteo.net>
 <87d0eqbgqt.fsf@ambrevar.xyz>
From: Guillaume Le Vaillant <glv@posteo.net>
In-reply-to: <87d0eqbgqt.fsf@ambrevar.xyz>
Date: Mon, 21 Oct 2019 12:05:13 +0200
Message-ID: <875zkibehy.fsf@yamatai>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: 37817@debbugs.gnu.org


Pierre Neidhardt skribis:

> Thanks for this patch.
>
> Everything is looking good, except the last patch where you should add an
> extra commit for the 'dot' package.
>
> Regarding the .asd patch: the lack of inferred package support is a
> general issue with our current build system.  Ideally, we could support
> it directly.  See this discussion for more details:
>
> https://gitlab.common-lisp.net/asdf/asdf/issues/10
>
> Would you be interested in working on it?  It might not be too hard :p

Ok, I'll put 'sbcl-graph-dot' and 'sbcl-graph-json' in their own
commits.

Also, I saw that there is a 'graph.scm' file with definitions of graph
related packages. Should I put 'sbcl-graph', 'sbcl-graph-dot' and
'sbcl-graph-json' in it, or should I keep them in 'lisp.scm'?