From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:57184)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMqhx-0006TP-3w
 for guix-patches@gnu.org; Tue, 22 Oct 2019 05:44:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMqhv-0002Ke-Uj
 for guix-patches@gnu.org; Tue, 22 Oct 2019 05:44:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:49428)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iMqhv-0002KZ-RA
 for guix-patches@gnu.org; Tue, 22 Oct 2019 05:44:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iMqht-00067t-MG
 for guix-patches@gnu.org; Tue, 22 Oct 2019 05:44:03 -0400
Subject: [bug#37853] [PATCH] gnu: Add ddcci-driver-linux.
Resent-Message-ID: <handler.37853.B.157173738823463@debbugs.gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:56935)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <m.othacehe@gmail.com>) id 1iMqgy-0005V1-Ea
 for guix-patches@gnu.org; Tue, 22 Oct 2019 05:43:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <m.othacehe@gmail.com>) id 1iMqgx-0001tf-CQ
 for guix-patches@gnu.org; Tue, 22 Oct 2019 05:43:04 -0400
Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:54243)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <m.othacehe@gmail.com>)
 id 1iMqgx-0001sc-6G
 for guix-patches@gnu.org; Tue, 22 Oct 2019 05:43:03 -0400
Received: by mail-wm1-x329.google.com with SMTP id i13so1144773wmd.3
 for <guix-patches@gnu.org>; Tue, 22 Oct 2019 02:43:02 -0700 (PDT)
References: <20191021151628.28632-1-brice@waegenei.re>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20191021151628.28632-1-brice@waegenei.re>
Date: Tue, 22 Oct 2019 11:42:58 +0200
Message-ID: <875zkh6rq5.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 37853@debbugs.gnu.org


Hello Brice,

> +             (url "https://gitlab.com/ddcci-driver-linux/ddcci-driver-li=
nux.git")

This line is too long. You can add a line break after "uri" so that it
fits under 78 columns.

> +         (replace 'build
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (for-each (lambda (module)
> +                         (invoke "make" "-C"
> +                                 (string-append (assoc-ref inputs "linux=
-module-builder")
> +                                                "/lib/modules/build")
> +                                 (string-append "M=3D" (getcwd) "/" modu=
le)))
> +                       (list "ddcci" "ddcci-backlight"))

It is a bit sad that we have to replicate 'build and 'install phases
because of those two subfolders. However, I can't see an easy way to
overcome this. Anyone?

> +a character device for each DDC/CI monitors in @file{/dev/bus/ddcci/[I=
=C2=B2C bus number]}.
> +ddcci-backlight allow the control of the backlight level or luminance pr=
operty when supported

As reported by guix lint, this line is too long. Also make sure that the
description starts by a full sentence, for instance: "This package
provides a pair of ...".

Can you send an updated patch?

Thanks,

Mathieu