unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: 37853@debbugs.gnu.org
Subject: [bug#37853] [PATCH] gnu: Add ddcci-driver-linux.
Date: Tue, 22 Oct 2019 11:42:58 +0200	[thread overview]
Message-ID: <875zkh6rq5.fsf@gmail.com> (raw)
In-Reply-To: <20191021151628.28632-1-brice@waegenei.re>


Hello Brice,

> +             (url "https://gitlab.com/ddcci-driver-linux/ddcci-driver-linux.git")

This line is too long. You can add a line break after "uri" so that it
fits under 78 columns.

> +         (replace 'build
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (for-each (lambda (module)
> +                         (invoke "make" "-C"
> +                                 (string-append (assoc-ref inputs "linux-module-builder")
> +                                                "/lib/modules/build")
> +                                 (string-append "M=" (getcwd) "/" module)))
> +                       (list "ddcci" "ddcci-backlight"))

It is a bit sad that we have to replicate 'build and 'install phases
because of those two subfolders. However, I can't see an easy way to
overcome this. Anyone?

> +a character device for each DDC/CI monitors in @file{/dev/bus/ddcci/[I²C bus number]}.
> +ddcci-backlight allow the control of the backlight level or luminance property when supported

As reported by guix lint, this line is too long. Also make sure that the
description starts by a full sentence, for instance: "This package
provides a pair of ...".

Can you send an updated patch?

Thanks,

Mathieu

  reply	other threads:[~2019-10-22  9:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 15:16 [bug#37853] [PATCH] gnu: Add ddcci-driver-linux Brice Waegeneire
2019-10-22  9:42 ` Mathieu Othacehe [this message]
2019-10-22 13:06   ` Danny Milosavljevic
2019-10-25  9:32 ` [bug#37853] Brice Waegeneire
2019-10-25  9:32   ` [bug#37853] [PATCH v2] gnu: Add ddcci-driver-linux Brice Waegeneire
2019-10-25  9:50     ` Mathieu Othacehe
2019-10-25 10:24 ` [bug#37853] Brice Waegeneire
2019-10-25 10:24   ` [bug#37853] [PATCH v3] gnu: Add ddcci-driver-linux Brice Waegeneire
2019-10-25 11:34   ` [bug#37853] Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zkh6rq5.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=37853@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).