From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:53778) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ia2Wl-000708-JZ for guix-patches@gnu.org; Wed, 27 Nov 2019 13:59:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ia2Wk-00069S-FC for guix-patches@gnu.org; Wed, 27 Nov 2019 13:59:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50249) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ia2Wk-00069G-CQ for guix-patches@gnu.org; Wed, 27 Nov 2019 13:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ia2Wk-0003bm-Bn for guix-patches@gnu.org; Wed, 27 Nov 2019 13:59:02 -0500 Subject: [bug#38403] [PATCH] gnu: Add intel-vaapi-driver-g45-h264. Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:53151) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ia2WD-0006tJ-9F for guix-patches@gnu.org; Wed, 27 Nov 2019 13:58:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ia2WB-0005LK-Kt for guix-patches@gnu.org; Wed, 27 Nov 2019 13:58:28 -0500 Received: from tobias.gr ([2001:470:7405::1]:44192) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ia2WA-0005JR-EY for guix-patches@gnu.org; Wed, 27 Nov 2019 13:58:27 -0500 References: <87y2w1uug9.fsf@jlicht.xyz> In-reply-to: <87y2w1uug9.fsf@jlicht.xyz> Date: Wed, 27 Nov 2019 19:58:19 +0100 Message-ID: <875zj59mes.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: 38403@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Jelle, Jelle Licht =E5=86=99=E9=81=93=EF=BC=9A > I am not sure if this package offers any practical benefit or=20 > not, so I > defer to someone who actually knows what they are talking about=20 > to make > a judgment call ;-). I don't have a G45, but if this driver verifiably works for you=20 (and the regular version does not) I think it's good to to include=20 it. Also because I expect this card to be overrepresented amongst=20 Guix users: there aren't that many common Librebootable machines. It needs its own clear synopsis, description, and home page=20 though. Is there a home page? I'm not good at navigating=20 BitBucket. > This variant of intel-vaapi-driver is a backport of the ancient=20 > g45-h264 > branch that used to be maintained by the intel-vaapi-driver=20 > team. As far > as I know, the reason they don't maintain this branch anymore is=20 > that > hardware accelerated h264 decoding on the G45 chipset was much=20 > too slow > for 1080p video, as by default it only had 32MB of VRAM to work=20 > with. These devices don't have their own RAM chips, so =E2=80=98by default=E2=80= =99 here=20 means the BIOS menu setting, right? If so, it should be mentioned=20 in the description for lack of upstream documentation. I'm guessing that your card identifies as an Intel=C2=AE GMA X4500MHD.=20 Is that correct? We should include the marketing name in the=20 synopsis & description too, even if it might not map 1:1 to the=20 chipset. > This variant of intel-vaapi-driver is a backport of the ancient=20 > g45-h264 > branch that used to be maintained by the intel-vaapi-driver=20 > team. As far > as I know, the reason they don't maintain this branch anymore is=20 > that > hardware accelerated h264 decoding on the G45 chipset was much=20 > too slow > for 1080p video, as by default it only had 32MB of VRAM to work=20 > with. This is good! :-) It should be slightly edited and used as a=20 description together with the original intel-vaapi-driver text. Apart from that, the package LGTM. Thanks! Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl3ex0sACgkQ2Imw8BjF STyxuA//VpCXPwBUI1N8uTdYzHO6DkhbmDlcpxV9PKvHAWQNGROrD+Z5XjcP+Srd QHR1rCqWMkNgCvcw8DX7P8QR4SHe7SB0kUtyZF5zPUOiLZW1SpTcI7qdaNbQ36yS tJXemW02JXredPhfm87QCGm0csGib6JlZfs4ph8R9eeWGTlaWLUllnlrJITkBJSG PuvnL8wYPuAlkWhbmZH54i2CVde815Y1DGb1poC03sTMtkWGI5TahEFHYWb8Vw1D sXOuApsKbn/mC0yfdLefkGlj1VJWdqPRQXYkXEfAKpEJHQPgjNFurdntboSdNCST yViI12dy4lCQnVKqTtrgjFwLInITMsGMcTnbqaW2HN6/wkIg3zsanWyN6wVGfNn1 yOXFQOdtSUEWsMVmakSFXXvkLkh0O24vIbq7CkEQg/a0MTB5rOHfNPrsBYbCbDn9 qRSUhs9XvaKiZtrYbzqYe19+FT95boUahYmUdGdnsIRp0dILG8Jb7d7eKdIhwTae qVScSeFQQEOtF+JUQwNzsKLBbmi46hSnfmnipNsuPN675WGmY+k/OIT0im7Owluh EEGiBb1Xmj67TYfCNJDO8EXvqwg+9nw1AKNYT3VYD9+NR62tv0bH7eVWnxDqlt6t RWCn3/HsYyhyl9kBLzlT4Tdzsx01JbBGqo1h/aW3PDXhBs8Q3KA= =8gG9 -----END PGP SIGNATURE----- --=-=-=--