From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:57673) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijSag-0008Tw-PG for guix-patches@gnu.org; Mon, 23 Dec 2019 13:38:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ijSaf-00018g-TA for guix-patches@gnu.org; Mon, 23 Dec 2019 13:38:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ijSaf-00018Y-Pq for guix-patches@gnu.org; Mon, 23 Dec 2019 13:38:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ijSaf-00071S-Nz for guix-patches@gnu.org; Mon, 23 Dec 2019 13:38:01 -0500 Subject: [bug#38687] [PATCH] gnu: Add libtcod. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20191220123739.18081-1-goodoldpaul@autistici.org> Date: Mon, 23 Dec 2019 19:37:18 +0100 In-Reply-To: <20191220123739.18081-1-goodoldpaul@autistici.org> (Giacomo Leidi's message of "Fri, 20 Dec 2019 13:37:39 +0100") Message-ID: <875zi6j3c1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Giacomo Leidi Cc: 38687@debbugs.gnu.org Hi, Giacomo Leidi skribis: > * gnu/packages/game-development.scm (libtcod): New variable. Could you (1) add a =E2=80=98snippet=E2=80=99 that removes zlib and utf8pro= c from src/vendor (assuming it doesn=E2=80=99t break the build system=E2=80=A6), a= nd (2) add utf8proc as an input? That way we=E2=80=99d make sure we don=E2=80=99t end up using bundled copie= s of these packages. Apart from that it LGTM, thanks! Ludo=E2=80=99.