unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 39873@debbugs.gnu.org
Subject: [bug#39873] [PATCH 1/3] substitute: Use the same port for multiple request batches.
Date: Sat, 07 Mar 2020 22:12:58 +0100	[thread overview]
Message-ID: <875zffg97p.fsf@gnu.org> (raw)
In-Reply-To: <20200302210735.13337-1-mail@cbaines.net> (Christopher Baines's message of "Mon, 2 Mar 2020 21:07:33 +0000")

Hi Christopher!

Christopher Baines <mail@cbaines.net> skribis:

> In http-multiple-get.

Leftover?  :-)

> * guix/scripts/substitute.scm (http-multiple-get): Switch port to p in one
> occurrence.
> ---
>  guix/scripts/substitute.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
> index dfb975a24a..5ed43d36c9 100755
> --- a/guix/scripts/substitute.scm
> +++ b/guix/scripts/substitute.scm
> @@ -545,7 +545,7 @@ initial connection on which HTTP requests are sent."
>               (()
>                (reverse result))
>               (remainder
> -              (connect port remainder result))))
> +              (connect p remainder result))))

LGTM!

Did you notice an occurrence of this bug somewhere?

Ludo’.

  parent reply	other threads:[~2020-03-07 21:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 21:02 [bug#39873] [PATCH 0/3] http-multiple-get enhancements Christopher Baines
2020-03-02 21:07 ` [bug#39873] [PATCH 1/3] substitute: Use the same port for multiple request batches Christopher Baines
2020-03-02 21:07   ` [bug#39873] [PATCH 2/3] substitute: Make http-multiple-get batch size configurable Christopher Baines
2020-03-07 21:13     ` Ludovic Courtès
2020-03-02 21:07   ` [bug#39873] [PATCH 3/3] substitute: Close port at the end of http-multiple-get Christopher Baines
2020-03-07 21:14     ` Ludovic Courtès
2020-03-08 23:58       ` Christopher Baines
2020-03-07 21:12   ` Ludovic Courtès [this message]
2020-03-09  0:07     ` [bug#39873] [PATCH 1/3] substitute: Use the same port for multiple request batches Christopher Baines
2020-04-26 18:40 ` bug#39873: [PATCH 0/3] http-multiple-get enhancements Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zffg97p.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=39873@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).