From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:57634)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jL0Nv-0001eS-M4
 for guix-patches@gnu.org; Sun, 05 Apr 2020 04:12:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jL0Nu-0001oG-PM
 for guix-patches@gnu.org; Sun, 05 Apr 2020 04:12:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:33587)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jL0Nu-0001nz-Ma
 for guix-patches@gnu.org; Sun, 05 Apr 2020 04:12:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jL0Nu-0007nK-Fg
 for guix-patches@gnu.org; Sun, 05 Apr 2020 04:12:02 -0400
Subject: [bug#40429] [PATCH] gnu: Add emacs-flymake-shellcheck.
Resent-Message-ID: <handler.40429.B40429.158607431229933@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <87o8s7p8lq.fsf@odyssey.lafreniere.xyz>
Date: Sun, 05 Apr 2020 10:11:41 +0200
In-Reply-To: <87o8s7p8lq.fsf@odyssey.lafreniere.xyz> (Joseph LaFreniere's
 message of "Sat, 04 Apr 2020 10:35:13 -0500")
Message-ID: <875zeecpxe.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "LaFreniere, Joseph" <joseph@lafreniere.xyz>
Cc: 40429@debbugs.gnu.org

Hello,

"LaFreniere, Joseph" <joseph@lafreniere.xyz> writes:

> Patch file is attached.

Thank you.

> +      (inputs
> +       `(("shellcheck" ,shellcheck)))
> +      (arguments
> +       '(#:phases
> +         (modify-phases %standard-phases
> +           (add-after 'unpack 'hardcode-shellcheck-path
> +             (lambda _
> +               (let ((file "flymake-shellcheck.el"))
> +                 (chmod file #o644)
> +                 (emacs-substitute-sexps file
> +                   ("(defcustom flymake-shellcheck-path"
> +                    (which "shellcheck")))))))))

You could use `emacs-substitute-variables' here.

However, I wonder if we should add "shellcheck" as an input. Of course,
the package will not work so well if "shellcheck" is not available. But,
as a user, it would not cross my mind to use "flymake-shellcheck"
without it. As another data point, "emacs-flycheck-rust" doesn't add
"rust" as an input.

WDYT?

Regards,

-- 
Nicolas Goaziou