From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56356) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOdLz-0008Ji-On for guix-patches@gnu.org; Wed, 15 Apr 2020 04:25:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOdLy-000872-Ne for guix-patches@gnu.org; Wed, 15 Apr 2020 04:25:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51922) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOdLy-00086t-Ka for guix-patches@gnu.org; Wed, 15 Apr 2020 04:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOdLy-0000yO-IH for guix-patches@gnu.org; Wed, 15 Apr 2020 04:25:02 -0400 Subject: [bug#40426] [PATCH] Add g-golf Resent-Message-ID: References: <6xX3P5wtqPLaHAJcG08vvndO5ruSKavzCs0khwcdJmF2CYVGjPLz_J-2HZXM7vCKOcAiSqWHMFPG1-rQA04EWZ9YPqh6KA090K1BOwlAhpY=@protonmail.com> <87eesq6iqq.fsf@cbaines.net> <87imi1z46t.fsf@gmail.com> From: Christopher Baines In-reply-to: <87imi1z46t.fsf@gmail.com> Date: Wed, 15 Apr 2020 09:24:47 +0100 Message-ID: <875ze16trk.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mike Rosset Cc: D0dyBo0D0dyBo0@protonmail.com, 40426@debbugs.gnu.org --=-=-= Content-Type: text/plain Mike Rosset writes: > Christopher Baines writes: > >> Vitaliy Shatrov via Guix-patches via writes: >> >> Does g-golf work with Guile 3 yet? If not, that's OK. >> > Hello Christopher, thanks for looking at this. > > I did quick look at seeing if g-golf would work with guile 3.0. But I > ran into some issue with core module bindings. Since g-golf very much > WIP and like wise Nomad which is my primary use for g-golf is also > WIP. I've kept strictly to guile 2.2 for now to maintain a little extra > stability. I'll follow up on it when both nomad a g-golf are more > stable. Sure, no problem. >> I don't quite follow this GUILE_GGOLF_UNINSTALLED environment >> variable. Why not just use the absolute filename for the so file >> (without the extension I think)? > > > The problem here is that libg-golf is needed both at compile time and > runtime. So it can not be substituted say after the unpack stage. So > this just checks if GUILE_GGOLF_UNINSTALLED is set. Then it will > use libg-golf with normal dynamic-link search paths. Other wise it uses > the full store path. > > I had discussed this scenario with the g-golf author, his > recommendation was to use this approach it's the same one used for the > guile-cv declaration. He's the author of guile-cv as well. Right, so it's something to help build the Guix package. I think I understand now. >> Also, maybe delete the strip phase, as I don't think that does anything >> apart from producing a load of warnings. >> > > I think the strip phase strips dynamic elf libraries as well? I > don't think it would hurt here to keep it for libg-golf at least? Sure, it's OK to keep it as well. > Would you also be able to look at bug#40512 Christopher? That one is a > trivial review just some upstream bug fixes for Emacsy and a hash bump > in the package declaration. Technically not related to the patch. But > eventually I'll need both of these when I release the next version of > nomad. I've gone ahead and merged the emacsy-minimal update, I'll send an email to that bug in a minute. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6WxM9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xf7Uw//QXXA4M39FgRLxzpxXNkCGwADPzChF9IXhGM+nXKrUF85dCNwNT3t0Z15 T0O5MYJUE6rs1+/vINtOOild/9e0HSrdwBWoyEbIoxLr1sjPndLnhz0xVZitqkc9 +gPQOOh5+sWpAQuxLtI5rXaa8W/nlSaP9mldvccLhHWHUL69gChF9bxYgCq5TYvO MA3KWkPMUZ8/fIbTb/fjSpLe4WjACWSWKsbh7sWiFpQTMpMupeQjgPsrSz0IC5E+ 71JvypUSdu4dW0XfSlYlNvY9CssgDkY5sRCkFu5LTHj07Q5tgSxnV3m56m7tFzUE pe8oR0gMPKYIoH6ax9YR9BbqlzaMqdAE8O3il7FDXzkJ2QhpEa2AY/cAPUpiqOFw 7z975KcDIhDW7OBENM7XBDA7gpjqR42xTI+j8BuUje9Q4epfUARHzcTmtq6hb+1z ZzYYnCTaTkzqiWWxj7JwKgoht7/y2R9uy/fo+rXZAZ79wZGOKgPWjPcTJbYwY5rb ixEkux9j9BNU3Wa9bbXyGqZzhpg6slPVLmyekqtutSepgejdZIbtniUOaUlLPVpp n5CDOobN3eyiDmzxlhsCX4iftI3ImYzniRjuBMVip0wbe+BnlZgsA6mJBUIkjxcK bUqDEAlgFH/QeNu3hQIpxLMqNsJPMTz2xTU+KJCBv4V7SfvadIg= =88l/ -----END PGP SIGNATURE----- --=-=-=--