From: Michael Rohleder <mike@rohleder.de>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 41327@debbugs.gnu.org
Subject: [bug#41327] [PATCH] gnu: Add emacs-vcsh.
Date: Tue, 19 May 2020 15:31:21 +0200 [thread overview]
Message-ID: <875zcsxd92.fsf@rohleder.de> (raw)
In-Reply-To: <87367zx0f9.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sat, 16 May 2020 19:19:22 +0200")
[-- Attachment #1.1: Type: text/plain, Size: 945 bytes --]
Hi Nicolas,
thank you for reviewing the patch.
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>> + (base32
>> + "183pffdiqb7qqmjq31wxl3fpv8qswqgg99gb716rddiyk15ysri7"))))
>
> Nitpick: could you move the string on the line above?
done.
>> + (description
>> + "This library only provides basic \"enter\" functionality
>> +(`vcsh-link', `vcsh-unlink') and a few convenience commands
>> +(`vcsh-new' to init a repo and add files to it,
>> +`vcsh-write-gitignore').
>
> Without writing too many details, I suggest
>
> This library provides basic ``enter'' functionality and a few
> convenience commands to init a repository and add files to it.
>
> However, it may be useful to write somewhere what is "vcsh". As a user,
> do I need/want that?
I modified the description to your suggesting and added a short
sentence, why/how this package could be useful.
e.g. I use it in this function (that i call from a hydra):
[-- Attachment #1.2: Type: application/emacs-lisp, Size: 125 bytes --]
[-- Attachment #1.3: Type: text/plain, Size: 37 bytes --]
> Could you send an updated patch?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.4: [PATCH] gnu: Add emacs-vcsh. --]
[-- Type: text/x-patch, Size: 1593 bytes --]
From 43a46ffd415ff780eda5dfeb5bd8de8ebaa04259 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Tue, 19 May 2020 15:05:16 +0200
Subject: [PATCH] gnu: Add emacs-vcsh.
* gnu/packages/emacs-xyz.scm (emacs-vcsh): New variable.
---
gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 69786f335b..77ab2977ee 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -14919,6 +14919,28 @@ repository, @code{magit-org-todos} will create a section in your Magit status
buffer with each of your todos.")
(license license:gpl3+))))
+(define-public emacs-vcsh
+ (package
+ (name "emacs-vcsh")
+ (version "0.4.4")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gitlab.com/stepnem/vcsh-el.git")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "183pffdiqb7qqmjq31wxl3fpv8qswqgg99gb716rddiyk15ysri7"))))
+ (build-system emacs-build-system)
+ (home-page "https://gitlab.com/stepnem/vcsh-el")
+ (synopsis "Emacs vcsh integration")
+ (description
+ "This library provides basic \"enter\" functionality and a few
+convenience commands to init a repo and add files to it. This is useful to
+use @code{magit} with a @code{vcsh} repo.")
+ (license license:public-domain)))
+
(define-public emacs-f3
(package
(name "emacs-f3")
--
2.26.2
[-- Attachment #1.5: Type: text/plain, Size: 10 bytes --]
Regards,
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-05-19 13:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 16:05 [bug#41327] [PATCH] gnu: Add emacs-vcsh Michael Rohleder
2020-05-16 17:19 ` Nicolas Goaziou
2020-05-19 13:31 ` Michael Rohleder [this message]
2020-05-20 10:44 ` bug#41327: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zcsxd92.fsf@rohleder.de \
--to=mike@rohleder.de \
--cc=41327@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).