From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YK0XK88k1l7UTAAA0tVLHw (envelope-from ) for ; Tue, 02 Jun 2020 10:07:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uO7/Js8k1l69OAAA1q6Kng (envelope-from ) for ; Tue, 02 Jun 2020 10:07:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0C9194014C for ; Tue, 2 Jun 2020 10:07:10 +0000 (UTC) Received: from localhost ([::1]:45266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jg3p7-0004Uf-HS for larch@yhetil.org; Tue, 02 Jun 2020 06:07:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jg3p0-0004UN-8C for guix-patches@gnu.org; Tue, 02 Jun 2020 06:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jg3oz-0004VY-US for guix-patches@gnu.org; Tue, 02 Jun 2020 06:07:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jg3oz-0005qZ-OZ for guix-patches@gnu.org; Tue, 02 Jun 2020 06:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41459] [PATCH] gnu: Add python-flask-restx Resent-From: Edouard Klein Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 Jun 2020 10:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41459 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 41459@debbugs.gnu.org Received: via spool by 41459-submit@debbugs.gnu.org id=B41459.159109238922436 (code B ref 41459); Tue, 02 Jun 2020 10:07:01 +0000 Received: (at 41459) by debbugs.gnu.org; 2 Jun 2020 10:06:29 +0000 Received: from localhost ([127.0.0.1]:37962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg3oT-0005pn-3B for submit@debbugs.gnu.org; Tue, 02 Jun 2020 06:06:29 -0400 Received: from sender4-op-o11.zoho.com ([136.143.188.11]:17199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jg3oR-0005pf-44 for 41459@debbugs.gnu.org; Tue, 02 Jun 2020 06:06:27 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1591092384; cv=none; d=zohomail.com; s=zohoarc; b=L9fkJyIJ7jtuYWYJDsGiXxmDMXXLjPTXtGiqceKPoL8C3+TCs97BeG5K5XeMOOBMwmYVY5XWsZhraqQQnfKPD55szlly7Yr11hQZ2+gItHCuCWA8UAX+NYrjJ3F/di4A68+L6+lZdoDw+phryzdrWE9+tzvMYG2FjN4KLI7gYnc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591092384; h=Content-Type:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Zm7s8Pk5veLCoIJPo8cuR2J9IEbx7DfZHPFIrHrDdQ0=; b=jOsgcdCpj5ouD0lvkqOzFQPRgZtKh29s2x8s9rQShlLgvnqHzOM6bE28CEjHUrjk3v3csN8MnEnG9leXculLSPibdZMLd6JORlgn/70Dw49DmbVie9/FYPTGB1NB69xDd9GzFHpoiaHd11qw9vaC0BdsEkjx9JVZv4aX8h80BVM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=rdklein.fr; spf=pass smtp.mailfrom=edou@rdklein.fr; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1591092384; s=zoho; d=rdklein.fr; i=edou@rdklein.fr; h=References:From:To:Subject:In-reply-to:Message-ID:Date:MIME-Version:Content-Type; bh=Zm7s8Pk5veLCoIJPo8cuR2J9IEbx7DfZHPFIrHrDdQ0=; b=fJMTliLsq9yE2nBRsP6PXpVoUi62ZJgkDL12rmrLg5wkifT2aHDWfap5SJonfxOH 7NCkrgMneHEN4DGWIACFHj3VceyFuGe435SP0l9YqNWBBWcMrrzpiSVGb0FV7Fj2Oha 73f6iO0yobMZ2ToRe9k+nJ/y+Rysrt5XUNQm2Bzg= Received: from alice.lan (lfbn-idf1-1-1299-119.w90-79.abo.wanadoo.fr [90.79.23.119]) by mx.zohomail.com with SMTPS id 1591092382194456.7317428509773; Tue, 2 Jun 2020 03:06:22 -0700 (PDT) References: <87a720au0g.fsf@alice.lan> <87mu5p1smg.fsf@gnu.org> User-agent: mu4e 1.4.6; emacs 26.3 From: Edouard Klein In-reply-to: <87mu5p1smg.fsf@gnu.org> Message-ID: <875zc9dbos.fsf@alice.lan> Date: Tue, 02 Jun 2020 12:06:11 +0200 MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=rdklein.fr header.s=zoho header.b=fJMTliLs; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.99 X-TUID: wLBVpJJGwjBF Hi, Thank you for reviewing the commits. For the indentation, I highlighted the changes in emacs and M-x indent-region, but it did not change anything. Is something wrong with my emacs config ? Cheers, Edouard Marius Bakke writes: > Edouard Klein writes: > >> * gnu/packages/python-web.scm (python-flask-restx): New variable. >> * gnu/packages/python-check.scm (python-pytest-benchmark): New variable. >> * gnu/packages/python-check.scm (python-pytest-flask): New variable. >> * gnu/packages/python-xyz.scm (python-py-cpuinfo): New variable. > > Can you split this into four different patches? > > Please also fix the indentation on each package. > >> diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm >> index 50911673b2..70db8445ee 100644 >> --- a/gnu/packages/python-check.scm >> +++ b/gnu/packages/python-check.scm >> @@ -362,6 +362,55 @@ framework.") >> framework.") >> (license license:expat))) >> >> +(define-public python-pytest-benchmark >> + (package >> + (name "python-pytest-benchmark") >> + (version "3.2.3") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "pytest-benchmark" version)) >> + (sha256 >> + (base32 >> + "0a4mpb4j73dsyk47hd1prrjpfk4r458s102cn80rf253jg818hxd")))) >> + (build-system python-build-system) >> + (native-inputs >> + `(("python-pathlib2" ,python-pathlib2) >> + ("python-py-cpuinfo" ,python-py-cpuinfo) >> + ("python-pytest" ,python-pytest))) > > py-cpuinfo should probably be propagated according to setup.py. > >> + (home-page "https://github.com/ionelmc/pytest-benchmark") >> + (synopsis >> + "Pytest fixture for benchmarking code") > > This line break is unnecessary. > > [...] > >> +(define-public python-pytest-flask >> + (package >> + (name "python-pytest-flask") >> + (version "1.0.0") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "pytest-flask" version)) >> + (sha256 >> + (base32 >> + "1hln7mwgdzfi5ma0kqfsi768l7p24jhkw8l0imhifwy08nh7hmjd")))) >> + (build-system python-build-system) >> + (native-inputs >> + `(("python-flask" ,python-flask) >> + ("python-pytest" ,python-pytest) >> + ("python-setuptools-scm" ,python-setuptools-scm) >> + ("python-werkzeug" ,python-werkzeug))) >> + (home-page >> + "https://github.com/pytest-dev/pytest-flask") >> + (synopsis >> + "Pytest fixtures to test Flask applications") > > These line breaks are unncessary. > >> +(define-public python-flask-restx >> + (package >> + (name "python-flask-restx") >> + (version "0.2.0") >> + (source >> + ;; We fetch from the Git repo because there are no tests in the PyPI >> + ;; archive. >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/python-restx/flask-restx") >> + (commit version))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "0xf2vkmdngp9cv9klznizai4byxjcf0iqh1pr4b83nann0jxqwy7")))) >> + (build-system python-build-system) >> + (propagated-inputs >> + `(("python-aniso8601" ,python-aniso8601) >> + ("python-flask" ,python-flask) >> + ("python-jsonschema" ,python-jsonschema) >> + ("python-pytz" ,python-pytz))) >> + (native-inputs >> + `(("python-blinker" ,python-blinker) >> + ("python-faker" ,python-faker) >> + ("python-pytest" ,python-pytest) >> + ("python-pytest-benchmark" >> + ,python-pytest-benchmark) >> + ("python-pytest-flask" ,python-pytest-flask) >> + ("python-pytest-mock" ,python-pytest-mock))) >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (replace 'check >> + (lambda _ >> + (invoke "pytest" "--benchmark-skip" "-k" >> + ;; Those tests need internet access >> + "not test_check and not test_valid_value_check")))))) >> + (home-page >> + "https://github.com/python-restx/flask-restx") > > This line break is unnecessary. > >> +(define-public python-py-cpuinfo >> + (package >> + (name "python-py-cpuinfo") >> + (version "5.0.0") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "py-cpuinfo" version)) >> + (sha256 >> + (base32 >> + "0045y6832gqjg63jmw0qj2jwyypgjwr7sfdq3lfv49b6fxpl5xic")))) >> + (build-system python-build-system) >> + (home-page >> + "https://github.com/workhorsy/py-cpuinfo") > > This line break is unnecessary. > >> + (synopsis "Get CPU info with pure Python 2 & 3") > > Maybe just "Get CPU info with Python" > >> + (description >> + "This module returns the CPU info by using the best sources of information for >> + your OS.") > > s/OS/operating system/ > > Can you send updated patches? Please also make sure they are in the > correct order, i.e. this last package must come before > 'python-pytest-benchmark'. > > Thanks in advance!