From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iANQAWzQ5F79XAAA0tVLHw (envelope-from ) for ; Sat, 13 Jun 2020 13:11:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sOzZOGvQ5F7RDgAAB5/wlQ (envelope-from ) for ; Sat, 13 Jun 2020 13:11:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EDB80940997 for ; Sat, 13 Jun 2020 13:11:06 +0000 (UTC) Received: from localhost ([::1]:46596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jk5w9-0001Jk-TQ for larch@yhetil.org; Sat, 13 Jun 2020 09:11:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jk5w6-0001JP-4p for guix-patches@gnu.org; Sat, 13 Jun 2020 09:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jk5w5-0005Xq-RR for guix-patches@gnu.org; Sat, 13 Jun 2020 09:11:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jk5w5-0000XW-NI for guix-patches@gnu.org; Sat, 13 Jun 2020 09:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41785] [PATCH v3 2/2] services: Add 'hurd-vm service-type'. Resent-From: Jan Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 Jun 2020 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41785 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 41785@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 41785-submit@debbugs.gnu.org id=B41785.15920538292037 (code B ref 41785); Sat, 13 Jun 2020 13:11:01 +0000 Received: (at 41785) by debbugs.gnu.org; 13 Jun 2020 13:10:29 +0000 Received: from localhost ([127.0.0.1]:41064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk5vZ-0000Wn-GI for submit@debbugs.gnu.org; Sat, 13 Jun 2020 09:10:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk5vX-0000Wb-MC for 41785@debbugs.gnu.org; Sat, 13 Jun 2020 09:10:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56652) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jk5vR-0005Py-MI; Sat, 13 Jun 2020 09:10:21 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=34708 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jk5vQ-0006wI-OS; Sat, 13 Jun 2020 09:10:21 -0400 From: Jan Nieuwenhuizen Organization: AvatarAcademy.nl References: <20200612214214.14112-1-janneke@gnu.org> <20200612214214.14112-2-janneke@gnu.org> <87imfvjfl8.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Sat, 13 Jun 2020 15:10:18 +0200 In-Reply-To: <87imfvjfl8.fsf@gnu.org> (Mathieu Othacehe's message of "Sat, 13 Jun 2020 14:49:23 +0200") Message-ID: <875zbvaz7p.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: y/G/Bj3Muy3u Mathieu Othacehe writes: Hey Mathieu! >> +(define (hurd-vm-disk-image config) >> + "Return a disk-image for the Hurd according to CONFIG." >> + (let ((os (hurd-vm-configuration-os config)) >> + (disk-size (hurd-vm-configuration-disk-size config)) >> + (target (and (not (%current-target-system)) "i586-pc-gnu")) >> + (base-image (find-image "ext2" (%current-target-system)))) >> + (with-parameters ((%current-target-system target)) >> + (system-image >> + (image (inherit base-image) >> + (size disk-size) >> + (operating-system os)))))) > > With the attached patch, you could write: > > (define (hurd-vm-disk-image config) > "Return a disk-image for the Hurd according to CONFIG." > (let ((os (hurd-vm-configuration-os config)) > (disk-size (hurd-vm-configuration-disk-size config))) > (system-image > (image > (inherit hurd-disk-image) > (size disk-size) > (operating-system os))))) > > WDYT? I like it a lot! Ludo already said adding target to image would be a good idea. Go for it! > From dbcfd86a74903cb0fe77843518625436d749ed09 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Sat, 13 Jun 2020 14:01:18 +0200 > Subject: [PATCH] image: Add 'target' support. This is already one step towards the image catalog, looks good to me! Note that I found https://bugs.gnu.org/41835 so I had to revert that patch in order to test...less than great; but I didn't want to push a revert without communicating about it first. Greetings, Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com