From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4CnYLOJH5l5sYgAA0tVLHw (envelope-from ) for ; Sun, 14 Jun 2020 15:53:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AC+UKOJH5l67IAAAbx9fmQ (envelope-from ) for ; Sun, 14 Jun 2020 15:53:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 52331940667 for ; Sun, 14 Jun 2020 15:53:06 +0000 (UTC) Received: from localhost ([::1]:48064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkUwT-0005Uc-AT for larch@yhetil.org; Sun, 14 Jun 2020 11:53:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkUwQ-0005US-Bn for guix-patches@gnu.org; Sun, 14 Jun 2020 11:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkUwQ-0007jd-2L for guix-patches@gnu.org; Sun, 14 Jun 2020 11:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkUwP-0001c1-WC for guix-patches@gnu.org; Sun, 14 Jun 2020 11:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41785] [PATCH v4] services: Add 'hurd-in-vm service-type'. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 14 Jun 2020 15:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41785 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jan Nieuwenhuizen Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 41785@debbugs.gnu.org Received: via spool by 41785-submit@debbugs.gnu.org id=B41785.15921499506157 (code B ref 41785); Sun, 14 Jun 2020 15:53:01 +0000 Received: (at 41785) by debbugs.gnu.org; 14 Jun 2020 15:52:30 +0000 Received: from localhost ([127.0.0.1]:44337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkUvt-0001bF-Vp for submit@debbugs.gnu.org; Sun, 14 Jun 2020 11:52:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkUvt-0001b2-1t for 41785@debbugs.gnu.org; Sun, 14 Jun 2020 11:52:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47656) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkUvn-0007hi-CD; Sun, 14 Jun 2020 11:52:23 -0400 Received: from [2a01:e0a:fa:a50:915b:bab1:f4c6:afb3] (port=57792 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jkUvm-0003G3-8c; Sun, 14 Jun 2020 11:52:23 -0400 From: Mathieu Othacehe References: <20200610085441.890-1-janneke@gnu.org> <87eeql9xvt.fsf@gnu.org> <87wo4d2rm5.fsf@gnu.org> <873670l3z9.fsf@gnu.org> <87eeqknf4d.fsf@gnu.org> <878sgpg856.fsf_-_@gnu.org> <87eeqhkea1.fsf@gnu.org> <87o8pleqg5.fsf@gnu.org> Date: Sun, 14 Jun 2020 17:52:19 +0200 In-Reply-To: <87o8pleqg5.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Sun, 14 Jun 2020 15:18:18 +0200") Message-ID: <875zbtk5l8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 7rbROZjeyXjJ > (define (hurd-multiboot-modules os) > ... > (libc (if target > (with-parameters ((%current-target-system #f)) > ;; TODO: cross-libc has extra patches for the Hurd; > ;; remove in next rebuild cycle > (cross-libc target)) > glibc)) > > we take the ELSE branch here -- and that does not work. AIUI, this is > really a temporary kludge until the next rebuild cycle we can move some > hurd-specific glibc patches from cross-libc to glibc-proper. Oh, I know why! In "system-image", there are a few calls, in the first let, that are outside the "with-parameters", in particular "bootcfg" which triggers the problem you are describing above. Maybe something as naive as: --8<---------------cut here---------------start------------->8--- diff --git a/gnu/system/image.scm b/gnu/system/image.scm index 1bda25fd7f..8a3c4e22d9 100644 --- a/gnu/system/image.scm +++ b/gnu/system/image.scm @@ -525,14 +525,14 @@ it can be used for bootloading." image, depending on IMAGE format." (define substitutable? (image-substitutable? image)) - (let* ((os (operating-system-for-image image)) - (image* (image-with-os image os)) - (target (image-target image)) - (register-closures? (has-guix-service-type? os)) - (bootcfg (operating-system-bootcfg os)) - (bootloader (bootloader-configuration-bootloader - (operating-system-bootloader os)))) - (with-parameters ((%current-target-system target)) + (with-parameters ((%current-target-system target)) + (let* ((os (operating-system-for-image image)) + (image* (image-with-os image os)) + (target (image-target image)) + (register-closures? (has-guix-service-type? os)) + (bootcfg (operating-system-bootcfg os)) + (bootloader (bootloader-configuration-bootloader + (operating-system-bootloader os)))) --8<---------------cut here---------------end--------------->8--- would do the trick. Thanks, Mathieu