unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: Vinicius Monego <monego@posteo.net>, 41953-done@debbugs.gnu.org
Cc: Vinicius Monego <monego@posteo.net>
Subject: bug#41953: [PATCH] gnu: darktable: Update to 3.0.2.
Date: Mon, 22 Jun 2020 23:11:13 +0200	[thread overview]
Message-ID: <875zbibyby.fsf@gnu.org> (raw)
In-Reply-To: <20200619201120.34116-1-monego@posteo.net>

[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]

Vinicius Monego <monego@posteo.net> writes:

> * gnu/packages/photo.scm (darktable): Update to 3.0.2.
> [arguments]: Compile with clang.
> [arguments]: Wrap GSETTINGS_SCHEMAS_DIR.
> [license]: Add license information for Rawspeed.
> [native-inputs]: Add clang.
> [native-inputs]: Add desktop-file-utils.
> [native-inputs]: Add glib.
> [native-inputs]: Add gobject-instrospection.
> [native-inputs]: Add llvm.
> [native-inputs]: Add po4a.
> [native-inputs]: Reorder alphabetically.
> [inputs]: Add colord-gtk.
> [inputs]: Add cups.
> [inputs]: Add graphicsmagick.
> [inputs]: Add gsettings-desktop-schemas.
> [inputs]: Add iso-codes.
> [inputs]: Add libsecret.
> [inputs]: Add lua.
> [inputs]: Add openjpeg.
> [inputs]: Add osm-gps-map.
> [inputs]: Reorder alphabetically.

Thanks!  I flattened this commit message so there is just a single entry
for each of the changed fields.

>         (modify-phases %standard-phases
> +         (add-before 'configure 'prepare-build-environment
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (setenv "CC" "clang") (setenv "CXX" "clang++")))

I tried building with GCC, and indeed it failed.  First because ISL was
not enabled, so I added 'gcc-9' which has it and adjusted
CPLUS_INCLUDE_PATH accordingly, but still ran into problems.

It would be good to move to GCC eventually because Clang is not nearly
as well tested.  :-)

Anyway thanks for the patch, applied!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2020-06-22 21:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 20:11 [bug#41953] [PATCH] gnu: darktable: Update to 3.0.2 Vinicius Monego
2020-06-22 21:11 ` Marius Bakke [this message]
2020-06-22 21:37   ` Vinicius Monego
2020-06-22 21:58     ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zbibyby.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=41953-done@debbugs.gnu.org \
    --cc=monego@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).