From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EI88HoKi815SVgAA0tVLHw (envelope-from ) for ; Wed, 24 Jun 2020 18:59:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mGXFGYKi816mTQAAB5/wlQ (envelope-from ) for ; Wed, 24 Jun 2020 18:59:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB9859400B7 for ; Wed, 24 Jun 2020 18:59:13 +0000 (UTC) Received: from localhost ([::1]:35844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joAc3-00005W-1V for larch@yhetil.org; Wed, 24 Jun 2020 14:59:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joAbu-0008UM-GH for guix-patches@gnu.org; Wed, 24 Jun 2020 14:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1joAbu-0004AQ-6Z for guix-patches@gnu.org; Wed, 24 Jun 2020 14:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1joAbu-0002cJ-4q for guix-patches@gnu.org; Wed, 24 Jun 2020 14:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41919] [patch] Add curlpp C++ bindings to curl package Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Jun 2020 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41919 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dale Mellor , 41919@debbugs.gnu.org Received: via spool by 41919-submit@debbugs.gnu.org id=B41919.159302511810028 (code B ref 41919); Wed, 24 Jun 2020 18:59:02 +0000 Received: (at 41919) by debbugs.gnu.org; 24 Jun 2020 18:58:38 +0000 Received: from localhost ([127.0.0.1]:39061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joAbW-0002bg-6O for submit@debbugs.gnu.org; Wed, 24 Jun 2020 14:58:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joAbS-0002bP-JF for 41919@debbugs.gnu.org; Wed, 24 Jun 2020 14:58:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53819) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joAbM-00044R-Qu; Wed, 24 Jun 2020 14:58:28 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:45534 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1joAbL-0001PO-5l; Wed, 24 Jun 2020 14:58:27 -0400 From: Marius Bakke In-Reply-To: <96308bdb48d4329a55b2201b64839b1aae5da160.camel@rdmp.org> References: <87v9jolf33.fsf@gnu.org> <96308bdb48d4329a55b2201b64839b1aae5da160.camel@rdmp.org> Date: Wed, 24 Jun 2020 20:58:24 +0200 Message-ID: <875zbg8f5b.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: JDSwAIFivVym --=-=-= Content-Type: text/plain Hello Dale, Thanks for the updated patch. I will suggest another few improvements, then I think it should be good to go. :-) Dale Mellor writes: > From b1506404e27552a171fe535144b2d11b6aa67cfa Mon Sep 17 00:00:00 2001 > From: Dale Mellor > Date: Sun, 21 Jun 2020 23:53:07 +0100 > Subject: [PATCH] gnu: Add curlpp library. > > * gnu/packages/curl.scm (curlpp): New variable. [...] > @@ -32,10 +33,12 @@ > #:use-module (guix download) > #:use-module (guix git-download) > #:use-module (guix utils) > + #:use-module (guix build-system cmake) > #:use-module (guix build-system gnu) > #:use-module (guix build-system go) > #:use-module (gnu packages) > #:use-module (gnu packages compression) > + #:use-module (gnu packages gawk) This import is unused. > #:use-module (gnu packages golang) > #:use-module (gnu packages guile) > #:use-module (gnu packages kerberos) > @@ -258,3 +261,33 @@ not offer a replacement for libcurl.") > Guile to do client-side URL transfers, like requesting documents from HTTP or > FTP servers. It is based on the curl library.") > (license license:gpl3+))) > + > +(define-public curlpp ^^ Extra space _____| > + (package > + (name "curlpp") > + (version "0.8.1") > + (source > + (origin > + (method git-fetch) What happened with the indentation here? Also, there is an extra space between 'method' and 'git-fetch'. > + (uri > + (git-reference Place git-reference on the same line as uri. > + (url "https://github.com/jpbarrette/curlpp.git") > + (commit "v0.8.1"))) Use (string-append "v" version) here instead of hard-coding. Also, you should add a (file-name (git-file-name name version)) in this vicinity. > + (sha256 > + (base32 "1b0ylnnrhdax4kwjq64r1fk0i24n5ss6zfzf4hxwgslny01xiwrk")))) > + (build-system cmake-build-system) ^^ Another extra space. > + ;; There are no build tests to be had. > + (arguments > + '(#:tests? #f)) > + ;; The installed version needs the header files from the C library. > + (propagated-inputs > + `(("curl" ,curl))) > + (synopsis "C++ wrapper around libcURL") ^^ Here too ______| > + (description > + "A free and easy-to-use client-side C++ URL transfer library, Please use full sentences in the description. In particular, start with "This package provides a ..." instead of jumping to the "A ...". > +supporting FTP, FTPS, HTTP, HTTPS, GOPHER, TELNET, DICT, FILE and LDAP; in > +particular it supports HTTPS certificates, HTTP POST, HTTP PUT, FTP uploading, > +kerberos, HTTP form based upload, proxies, cookies, user+password > +authentication, file transfer resume, http proxy tunneling and more!") > + (home-page "http://www.curlpp.org") > + (license license:x11-style))) There are extra spaces after 'home-page' and 'license'. Also, license:x11-style is a procedure that takes two arguments: an URI and optionally a comment. However reading the source files, it looks like the standard "Expat" license, so you can use license:expat instead. Can you send an updated patch? TIA! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7zolEACgkQoqBt8qM6 VPrtNQf+Ou8/wN3R6sGXzjTIoZeF8SpTfA92CVd2+JTYB+vL8oESC2/17zhzLIGK pbbRwwaLitUbp8SEhHtR70ntk2M95mjKkF9eP99WVVWZTWjvEpKB2BQNw4v7Pdpp 9aI3MqJ2x+xA7/nucOp9uUvmerDD52oVtR1YC3or9nHeIQVpOFOd5dhHY/NiG/we H2irwKOYYYY6cspbD++VgZ4UUG5w3G3Yjgs9KLvFgzkl7KMBYTmdB0lohwPTgitk HETcYkkHV1MAUwHDL+gHLBfp2kRiufGtT9s7heEBZIRPwUyG/AMf2N2QyvEY0ZMT pd/wjN484DDXYxLXPe6WFC+Wk0sVzw== =hIqj -----END PGP SIGNATURE----- --=-=-=--