From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qPRxMv6aQ1+QfQAA0tVLHw (envelope-from ) for ; Mon, 24 Aug 2020 10:48:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MJAgLv6aQ19MPQAAbx9fmQ (envelope-from ) for ; Mon, 24 Aug 2020 10:48:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3298694053D for ; Mon, 24 Aug 2020 10:48:30 +0000 (UTC) Received: from localhost ([::1]:39802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAA1b-00056L-FS for larch@yhetil.org; Mon, 24 Aug 2020 06:48:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAA1I-00056B-OE for guix-patches@gnu.org; Mon, 24 Aug 2020 06:48:08 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAA1C-0004Hx-46 for guix-patches@gnu.org; Mon, 24 Aug 2020 06:48:08 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAA1C-0007PP-2d for guix-patches@gnu.org; Mon, 24 Aug 2020 06:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42899] [PATCH v2 04/10] gnu: dovecot-pigeonhole: Add new variable. Resent-From: Alexey Abramov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 Aug 2020 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42899 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 42899@debbugs.gnu.org Received: via spool by 42899-submit@debbugs.gnu.org id=B42899.159826604028430 (code B ref 42899); Mon, 24 Aug 2020 10:48:02 +0000 Received: (at 42899) by debbugs.gnu.org; 24 Aug 2020 10:47:20 +0000 Received: from localhost ([127.0.0.1]:56207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAA0V-0007OU-QG for submit@debbugs.gnu.org; Mon, 24 Aug 2020 06:47:20 -0400 Received: from mx4.mail.mmer.org ([178.22.66.29]:13089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAA0R-0007OJ-4f for 42899@debbugs.gnu.org; Mon, 24 Aug 2020 06:47:18 -0400 Received: from delta (92-109-1-225.cable.dynamic.v4.ziggo.nl [92.109.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx4.mail.mmer.org (Postfix) with ESMTPSA id 0D2E49CC2E; Mon, 24 Aug 2020 10:16:22 +0000 (UTC) From: Alexey Abramov References: <20200818120037.30722-1-levenson@mmer.org> <20200818120037.30722-4-levenson@mmer.org> <20200823211651.GB1392@E5400> Date: Mon, 24 Aug 2020 12:47:08 +0200 In-Reply-To: <20200823211651.GB1392@E5400> (Efraim Flashner's message of "Mon, 24 Aug 2020 00:16:51 +0300") Message-ID: <875z987237.fsf@mmer.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: MU1sXC1MUcZc --=-=-= Content-Type: text/plain Efraim Flashner writes: > Make sure you run 'guix lint' on the package, some of the lines are too > long. > [...] > > Is there a difference between dovecot-2.3-pigeonhole-0.5.11.tar.gz and > dovecot-2.3.11-pigeonhole-0.5.11.tar.gz? Hm, I didn't even know that you can download the latter one. I used the URL provided from the [1] Anyways, I have downloaded both of them and did a check. Most of the differences relate to Makefile.in, however I also found that the ChangeLog file from "2.3" is newer then "2.3.11". The latter miss one change. Please see the diff I have attached. So I guess we should use dovecot-2.3-pigeonhole-0.5.11.tar.gz. > [...] > > it doesn't looke like automake, autoconf, libtool or gettext are > necessary here. Also, 'guix gc --references' show a reference to > dovecot, so that should go in inputs. It is indeed not required. I removed native-imports completely and everithing builds OK. I also moved dovecot to inputs, checked 'guix gc --references', but it turned out that it shows dovecot anyways. ,----[ guix gc --references /gnu/store/c6lnlfqh0jxkrz1x8mk7gdpx15iffxqd-dovecot-pigeonhole-0.5.11/ ] | /gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7.5.0-lib | /gnu/store/c6lnlfqh0jxkrz1x8mk7gdpx15iffxqd-dovecot-pigeonhole-0.5.11 | /gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31 | /gnu/store/hcxpkksmbql6s4al8yy2myr25kh4cic0-openssl-1.1.1g | /gnu/store/mhwawv2afb40xv96mdanr2qlqkj6wh8m-dovecot-2.3.11.3 `---- As I understood, it means that if someone have dovecot and dovecot-pigeonhole installed, and the decide to remove pigeonhole, dovecot will be GCed. Please correct me if am wrong. > [...] > > If you change the lambda to (lambda* (#:key outputs #:allow-other-keys) > then you can change the let to (let ((out (assoc-ref outputs "out"))) > and it fits better with the code formatting in the rest of Guix. Done. > [...] > > Some of these lines are too long. We try to wrap them at 80, and the > linter complains once it hits 90. If you start a new line after 'out' > then it should flow nicely. Done. Yeah, I saw this, but decided that separating the last argument is not that pretty. > [...] > > I would shorten this to 'Mail filtering in Dovecot using the Sieve > language' Done. I am fine with that. As a non native speaker I usually prefer not to touch these kind of things, until I am really sure it can be improved. =) [...] > > It looked to me like it was just lgpl2.1 Sorry, I am not following. I removed the comment I left indeed. Do you mean I should remove (license:non-copyleft "file://COPYING") the part completely? The blob contains both COPYING and COPYING.LGPL so I just copied them both. Footnotes: [1] https://pigeonhole.dovecot.org/download.html -- Alexey --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=pigeonhole.2.3-to-2.3.11.diff --- /home/levenson/Downloads/dovecot-2.3-pigeonhole-0.5.11/ChangeLog 2020-08-13 09:11:59.000000000 +0200 +++ /home/levenson/Downloads/dovecot-2.3.11-pigeonhole-0.5.11/ChangeLog 2020-08-12 14:21:42.000000000 +0200 @@ -1,11 +1,3 @@ -2020-08-13 07:45:38 +0300 Aki Tuomi (d71e0372) - - configure: Fix version number - - Broken by ebadd718b918a552fce65ccae6ebaff9d482eb16 - -M configure.ac - 2020-06-30 11:53:28 +0300 Aki Tuomi (6c69c917) NEWS: Add news for 0.5.11 --=-=-=--