From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0KdJIMYkVl/5MAAA0tVLHw (envelope-from ) for ; Mon, 07 Sep 2020 12:17:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aKJCHMYkVl86BgAAB5/wlQ (envelope-from ) for ; Mon, 07 Sep 2020 12:17:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 09C909401D0 for ; Mon, 7 Sep 2020 12:17:10 +0000 (UTC) Received: from localhost ([::1]:32930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFG56-0004rY-W7 for larch@yhetil.org; Mon, 07 Sep 2020 08:17:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFG50-0004q0-Mn for guix-patches@gnu.org; Mon, 07 Sep 2020 08:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFG50-0008PC-Cl for guix-patches@gnu.org; Mon, 07 Sep 2020 08:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFG50-0006a5-7O for guix-patches@gnu.org; Mon, 07 Sep 2020 08:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43204] [PATCH] gnu: taglib: Propagate zlib. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Sep 2020 12:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: mike@rohleder.de, 43204@debbugs.gnu.org Received: via spool by 43204-submit@debbugs.gnu.org id=B43204.159948096625226 (code B ref 43204); Mon, 07 Sep 2020 12:17:02 +0000 Received: (at 43204) by debbugs.gnu.org; 7 Sep 2020 12:16:06 +0000 Received: from localhost ([127.0.0.1]:48315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFG3z-0006YD-Pb for submit@debbugs.gnu.org; Mon, 07 Sep 2020 08:16:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFG3u-0006Xt-Hn for 43204@debbugs.gnu.org; Mon, 07 Sep 2020 08:15:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41512) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFG3o-0008Fb-3M; Mon, 07 Sep 2020 08:15:48 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=43964 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kFG3n-0000nc-Lg; Mon, 07 Sep 2020 08:15:47 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200904153824.27164-1-mike@rohleder.de> <87363xmsfx.fsf@gmx.com> <87wo18piv4.fsf@gmx.com> Date: Mon, 07 Sep 2020 14:15:41 +0200 In-Reply-To: <87wo18piv4.fsf@gmx.com> (Pierre Langlois's message of "Sat, 05 Sep 2020 12:23:43 +0100") Message-ID: <875z8pkck2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: tot3Yco313w4 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! Pierre Langlois skribis: > Actually, thinking about this a little more, I'm not sure I understand > upstream decision to propagate -lz. The commit fixes [0] which indicates > it's so that taglib can be linked statically, but then that means if > we're dynamically linking, the application will also dynamically link > with zlib when it doesn't need to (at least not directly). And in guix > we only build shared libs for taglib so we're never statically linking > it AFAIK. > > So, here I'm a bit torn here, should we just follow what upstream is > indicating? Even it doesn't look right to me, but I might be wrong! Or, > should we revert the change that propagates -lz? I had the following patch that I intended to push, to avoid propagation. WDYT? Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable commit d8124a707602980556fd33c7dbf9f7483fe1d0df Author: Ludovic Court=C3=A8s Date: Mon Sep 7 09:56:08 2020 +0200 gnu: taglib: 'taglib-config --libs' shows -L flag for zlib. =20=20=20=20 Fixes compilation of emacs-emms-print-metadata. =20=20=20=20 * gnu/packages/mp3.scm (taglib)[arguments]: Add #:phases. diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index 7ee009df74..a7574f0cf9 100644 --- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -1,6 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2013 Andreas Enge -;;; Copyright =C2=A9 2014, 2015, 2017 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2014, 2015, 2017, 2020 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2015 Mark H Weaver ;;; Copyright =C2=A9 2016 Efraim Flashner ;;; Copyright =C2=A9 2017 Thomas Danckaert @@ -174,7 +174,18 @@ a highly stable and efficient implementation.") (build-system cmake-build-system) (arguments '(#:tests? #f ; Tests are not ran with BUILD_SHARED_LIBS on. - #:configure-flags (list "-DBUILD_SHARED_LIBS=3DON"))) + #:configure-flags (list "-DBUILD_SHARED_LIBS=3DON") + #:phases (modify-phases %standard-phases + (add-before 'configure 'adjust-zlib-ldflags + (lambda* (#:key inputs #:allow-other-keys) + ;; Make sure users of 'taglib-config --libs' get th= e -L + ;; flag for zlib. + (substitute* "CMakeLists.txt" + (("set\\(ZLIB_LIBRARIES_FLAGS -lz\\)") + (string-append "set(ZLIB_LIBRARIES_FLAGS -L" + (assoc-ref inputs "zlib") + " -lz)"))) + #t))))) (inputs `(("zlib" ,zlib))) (home-page "https://taglib.org") (synopsis "Library to access audio file meta-data") --=-=-=--