unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Malte Frank Gerdes <malte.f.gerdes@gmail.com>
Cc: 44342@debbugs.gnu.org
Subject: [bug#44342] [PATCH 2/6] gnu: cpp: Update rct to e706998697b8d48fa9e5b9ab33aeded705129a66.
Date: Sat, 07 Nov 2020 11:03:27 +0100	[thread overview]
Message-ID: <875z6hjxg0.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20201031141118.21536-2-malte.f.gerdes@gmail.com> (Malte Frank Gerdes's message of "Sat, 31 Oct 2020 15:11:14 +0100")

Hello,

Malte Frank Gerdes <malte.f.gerdes@gmail.com> writes:

> * gnu/packages/cpp.scm (rct): Update variable.
> * gnu/packages/patches/rct-add-missing-headers.patch: Adjust
> accordingly.

Thank you.

> -  (let* ((commit "b3e6f41d9844ef64420e628e0c65ed98278a843a")
> -         (revision "2"))
> +  (let* ((commit "e706998697b8d48fa9e5b9ab33aeded705129a66")
> +         (revision "0"))

Why are you resetting revision here? This is going to break version
comparison, isn't it?

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2020-11-07 10:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-31 14:07 [bug#44342] [PATCH 0/6] Update rtags and add rtags related emacs packages Malte Frank Gerdes
2020-10-31 14:11 ` [bug#44342] [PATCH 1/6] gnu: code: Update RTags to 2.38 Malte Frank Gerdes
2020-10-31 14:11   ` [bug#44342] [PATCH 2/6] gnu: cpp: Update rct to e706998697b8d48fa9e5b9ab33aeded705129a66 Malte Frank Gerdes
2020-11-07 10:03     ` Nicolas Goaziou [this message]
2020-10-31 14:11   ` [bug#44342] [PATCH 3/6] gnu: Add emacs-rtags Malte Frank Gerdes
2020-10-31 14:11   ` [bug#44342] [PATCH 4/6] gnu: Add emacs-flycheck-rtags Malte Frank Gerdes
2020-11-07 10:41     ` Nicolas Goaziou
2020-10-31 14:11   ` [bug#44342] [PATCH 5/6] gnu: Add emacs-helm-rtags Malte Frank Gerdes
2020-10-31 14:11   ` [bug#44342] [PATCH 6/6] gnu: Add emacs-company-rtags Malte Frank Gerdes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z6hjxg0.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=44342@debbugs.gnu.org \
    --cc=malte.f.gerdes@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).