From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iBhTNMt3wl/RDQAA0tVLHw (envelope-from ) for ; Sat, 28 Nov 2020 16:16:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +G4iMMt3wl/DKwAA1q6Kng (envelope-from ) for ; Sat, 28 Nov 2020 16:16:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 41F0D9402A8 for ; Sat, 28 Nov 2020 16:16:11 +0000 (UTC) Received: from localhost ([::1]:37436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kj2tO-000111-63 for larch@yhetil.org; Sat, 28 Nov 2020 11:16:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kj2tG-0000zT-Oq for guix-patches@gnu.org; Sat, 28 Nov 2020 11:16:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37342) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kj2tG-0007NK-H2 for guix-patches@gnu.org; Sat, 28 Nov 2020 11:16:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kj2tG-0003A3-CM for guix-patches@gnu.org; Sat, 28 Nov 2020 11:16:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44768] [PATCH v3 2/2] gnu: Add lightspark. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 28 Nov 2020 16:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44768 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 44768@debbugs.gnu.org Received: via spool by 44768-submit@debbugs.gnu.org id=B44768.160658010712063 (code B ref 44768); Sat, 28 Nov 2020 16:16:02 +0000 Received: (at 44768) by debbugs.gnu.org; 28 Nov 2020 16:15:07 +0000 Received: from localhost ([127.0.0.1]:48888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj2sM-00038V-NJ for submit@debbugs.gnu.org; Sat, 28 Nov 2020 11:15:07 -0500 Received: from mira.cbaines.net ([212.71.252.8]:33384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj2sK-00038L-NN for 44768@debbugs.gnu.org; Sat, 28 Nov 2020 11:15:05 -0500 Received: from localhost (188.28.112.52.threembb.co.uk [188.28.112.52]) by mira.cbaines.net (Postfix) with ESMTPSA id 1EA1A27BBF8; Sat, 28 Nov 2020 16:15:04 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 55912876; Sat, 28 Nov 2020 16:15:01 +0000 (UTC) References: <20201125171857.28120-1-monego@posteo.net> <20201125171857.28120-2-monego@posteo.net> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <20201125171857.28120-2-monego@posteo.net> Date: Sat, 28 Nov 2020 16:15:01 +0000 Message-ID: <875z5ptq4a.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.87 X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-TUID: EjH4/iagaXBy --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vinicius Monego writes: > * gnu/packages/animation.scm (lightspark): New variable. > --- > Rebased on the previous commit Thanks for the patch, the main thing I noticed with this is that there's some bundled code, at least I spotted pugixml included in the lightspark code, and Guix already has a package for pugixml. If possible, lightspark should be built with pugixml from Guix. > gnu/packages/animation.scm | 64 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/gnu/packages/animation.scm b/gnu/packages/animation.scm > index 102b0f47f7..9b94c1d214 100644 > --- a/gnu/packages/animation.scm > +++ b/gnu/packages/animation.scm > @@ -25,9 +25,11 @@ > #:use-module (guix git-download) > #:use-module (guix utils) > #:use-module ((guix licenses) #:prefix license:) > + #:use-module (guix build-system cmake) > #:use-module (guix build-system gnu) > #:use-module (gnu packages) > #:use-module (gnu packages algebra) > + #:use-module (gnu packages assembly) > #:use-module (gnu packages autotools) > #:use-module (gnu packages boost) > #:use-module (gnu packages compression) > @@ -43,6 +45,8 @@ > #:use-module (gnu packages image) > #:use-module (gnu packages imagemagick) > #:use-module (gnu packages jemalloc) > + #:use-module (gnu packages networking) > + #:use-module (gnu packages pcre) > #:use-module (gnu packages perl) > #:use-module (gnu packages pkg-config) > #:use-module (gnu packages pulseaudio) > @@ -397,3 +401,63 @@ audio or video backends, ensuring good performance.") > (home-page "https://www.gnu.org/software/gnash/") > (license license:gpl3+)))) >=20=20 > +(define-public lightspark > + (package > + (name "lightspark") > + (version "0.8.3") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/lightspark/lightspark") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0rgqqppnv4n3kv623sgr1zpc2fdsnrqzfiqgk4clcmfl5ipklg6f"))= )) > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f ;requires Adobe Flex SDK, see README.tests > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'relative-etc-dir > + ;; Write default config file to ./etc instead of /etc. > + (lambda _ > + (substitute* "CMakeLists.txt" (("\\/etc") "etc")) > + #t)) > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (if tests? > + (begin > + (invoke "./tests")) > + #t)))))) I'd normally write this as: (when tests? (invoke "./tests")) #t > + (native-inputs > + `(("gettext" ,gettext-minimal) > + ("glib:bin" ,glib "bin") > + ("nasm" ,nasm) > + ("perl" ,perl) > + ("pkg-config" ,pkg-config) > + ("python" ,python-wrapper))) > + (inputs > + `(("cairo" ,cairo) > + ("curl" ,curl) > + ("ffmpeg" ,ffmpeg) > + ("freeglut" ,freeglut) > + ("glew" ,glew) > + ("glibmm" ,glibmm) > + ("gnash" ,gnash) > + ("libjpeg" ,libjpeg-turbo) > + ("openssl" ,openssl) > + ("pango" ,pango) > + ("pcre2" ,pcre2) > + ("rtmpdump" ,rtmpdump) > + ("sdl2" ,sdl2) > + ("sdl2-mixer" ,sdl2-mixer) > + ("zlib" ,zlib))) > + (home-page "https://lightspark.github.io/") > + (synopsis "Flash player implementation") > + (description > + "Lightspark is a Flash player implementation for playing files in t= he SWF > +format. Lightspark can run as a web browser plugin or as a standalone > +application. Lightspark supports SWF files written on all versions of t= he > +ActionScript language.") > + (license license:lgpl3+))) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/Cd4VfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfU1Q/+KiU2IZj2uO7jW6jkhH6oIFf8a+X9XKA7 dgBFcAXjBgyQ6fl/DKH/k7rvS4ezL/4Py9tSlRTNqn0BYMinbK+W1/oOf6d7FOyx MGWjd+Ek/01XAKZ6vn1X2XqOOREpXx//5ig2FAiy1UDAzf8U/XY+k2vE3riPfo6V ws3r1tx90Ay+O2k2QzNyUCvVPISvTl/pcrBLwzq0h9QVfki2wYBPCBPIsosTx8xL TZhbAcWpW4IJWqw3wL+zoo4ggHRyGv5DMhbzOj4tvBlDsIepqt4Q33CscEKfOxUM AUMWXEHAchqAfHPBFHndDycn3FBKo6NxwjULt/RgdE3uvxFoau3hLHGkOcm83EiC E/kzBOzOvogVY9nfi7XKng8FymDzn/JvVbRLwXeXyxOlPDeUrMIUjS3k88R0kzxv JIW4avdUW/17BIRZRhfjD1KK7iPY7Fx9DJaWaXyiZMlT2fO9dom8hPDfXlJgBbhD yJeyXjbPJGLfPCNiNfFgwPY830JRzPvVohb6ugDmUjXtQ3D//3woeoXypIIEN/A+ mb+fGH3U5+ZIHIxcTNeEZLDceMPx9kA6MGZGcweOGQb1jqPISms1Qch8Qt4HlSBx kkruhGUanYHEfubpGk0eP1SiigpJfhISzrs72Hb1Ib1UZIoiPKP46mfX0gut2GdW XyKrQc1VvoI= =d6SQ -----END PGP SIGNATURE----- --=-=-=--