From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id jiFFOhZnA2ArCQAA0tVLHw (envelope-from ) for ; Sat, 16 Jan 2021 22:22:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EE5xNRZnA2AyeAAAbx9fmQ (envelope-from ) for ; Sat, 16 Jan 2021 22:22:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B1222940481 for ; Sat, 16 Jan 2021 22:22:14 +0000 (UTC) Received: from localhost ([::1]:42310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0txV-0004Z3-Nx for larch@yhetil.org; Sat, 16 Jan 2021 17:22:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0tXC-0007b3-EU for guix-patches@gnu.org; Sat, 16 Jan 2021 16:55:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0tXC-0001DC-1W for guix-patches@gnu.org; Sat, 16 Jan 2021 16:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0tXB-00010y-Ry for guix-patches@gnu.org; Sat, 16 Jan 2021 16:55:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44249] [PATCH] gnu: emacs: Make strip-double-wrap more robust Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Jan 2021 21:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44249 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Morgan Smith Received: via spool by 44249-submit@debbugs.gnu.org id=B44249.16108340793866 (code B ref 44249); Sat, 16 Jan 2021 21:55:01 +0000 Received: (at 44249) by debbugs.gnu.org; 16 Jan 2021 21:54:39 +0000 Received: from localhost ([127.0.0.1]:44167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0tWp-00010I-6p for submit@debbugs.gnu.org; Sat, 16 Jan 2021 16:54:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0tWn-000105-IP for 44249@debbugs.gnu.org; Sat, 16 Jan 2021 16:54:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58709) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0tWh-00013v-Pq; Sat, 16 Jan 2021 16:54:31 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=37652 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l0tWh-00021j-CI; Sat, 16 Jan 2021 16:54:31 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <874kjiz5vp.fsf_-_@gnu.org> Date: Sat, 16 Jan 2021 22:54:29 +0100 In-Reply-To: (Morgan Smith's message of "Fri, 15 Jan 2021 14:49:15 -0500") Message-ID: <875z3wy2cq.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44249@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B1222940481 X-Spam-Score: -2.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: KoHYahZAYUNg Hi, Morgan Smith skribis: > I've actually been sorta half working on this for a while now. > > The problem is exactly that the modules field is inherited. See each > build system includes its own module in the modules field. The various > emacsen are built with different build systems. So emacs is going to > need to import (guix build glib-or-gtk-build-system) and emacs-minimal > is going to want (guix build gnu-build-system). By setting the modules > to be the glib-or-gtk-build-system, we override the default modules in > each inherited package. This means building emacs-minimal would result > in this error: > > no code for module (guix build glib-or-gtk-build-system) Ooh, my bad, I had completely overlooked this =E2=80=9Cdetail=E2=80=9D. Then I guess the patch is fine though=E2=80=A6 in this case you could exceptionally ;-) write (car (find-files =E2=80=A6)) so you don=E2=80=99t e= ven need to both importing (ice-9 match). That=E2=80=99d save quite a few lines of cod= e. WDYT? Thanks! Ludo=E2=80=99.