From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sJMbLcq1MWDFXAAA0tVLHw (envelope-from ) for ; Sun, 21 Feb 2021 01:22:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eLf3KMq1MWBLSgAAbx9fmQ (envelope-from ) for ; Sun, 21 Feb 2021 01:22:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CE83923E6D for ; Sun, 21 Feb 2021 02:22:17 +0100 (CET) Received: from localhost ([::1]:57212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDdRw-0004WQ-KH for larch@yhetil.org; Sat, 20 Feb 2021 20:22:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDdRi-0004WF-EW for guix-patches@gnu.org; Sat, 20 Feb 2021 20:22:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41721) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDdRi-0008Sx-6c for guix-patches@gnu.org; Sat, 20 Feb 2021 20:22:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lDdRi-0003wo-2l for guix-patches@gnu.org; Sat, 20 Feb 2021 20:22:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46231] Add emilua Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Feb 2021 01:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46231 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: =?UTF-8?Q?Vin=C3=ADcius?= dos Santos Oliveira Cc: 46231@debbugs.gnu.org Received: via spool by 46231-submit@debbugs.gnu.org id=B46231.161387051715163 (code B ref 46231); Sun, 21 Feb 2021 01:22:02 +0000 Received: (at 46231) by debbugs.gnu.org; 21 Feb 2021 01:21:57 +0000 Received: from localhost ([127.0.0.1]:53267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDdRd-0003wU-74 for submit@debbugs.gnu.org; Sat, 20 Feb 2021 20:21:57 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:38123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDdRZ-0003wD-2E for 46231@debbugs.gnu.org; Sat, 20 Feb 2021 20:21:55 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 2C268240002; Sun, 21 Feb 2021 01:21:44 +0000 (UTC) From: Nicolas Goaziou References: Date: Sun, 21 Feb 2021 02:21:42 +0100 In-Reply-To: ("=?UTF-8?Q?Vin=C3=ADcius?= dos Santos Oliveira"'s message of "Mon, 1 Feb 2021 07:00:42 -0300") Message-ID: <875z2mxljt.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.37 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CE83923E6D X-Spam-Score: -2.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: B/y14ybtPpqp Hello, Vin=C3=ADcius dos Santos Oliveira writes: > I've created a new package for guix. Here's its definition: > https://gitlab.com/emilua/emilua/-/snippets/2068658 Thank you! > Please let me know if it has any issues so I can fix them until it's > ready for inclusion in the main repository. There are some issue to fix: - the name of the custom luajit2 package should be changed. Maybe openresty-luajit? - that package should have a proper version and build tag out of it. - I see that emilua uses #:recursive? set to #true. Could some submodules could be unbundled by any chance? - You disabled tests. I would be nice to provide a reason for that. - You don't need `string-append' in the description. Just write the full textin a single string. Could you split this into two patches and send them here, for easier review? Regards, --=20 Nicolas Goaziou