From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qHkTEWzZMmCIVwAA0tVLHw (envelope-from ) for ; Sun, 21 Feb 2021 22:06:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iLHrDGzZMmBgHwAA1q6Kng (envelope-from ) for ; Sun, 21 Feb 2021 22:06:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 32FB81C540 for ; Sun, 21 Feb 2021 23:06:35 +0100 (CET) Received: from localhost ([::1]:46028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDws6-0007iA-BF for larch@yhetil.org; Sun, 21 Feb 2021 17:06:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDwra-0007gx-Sz for guix-patches@gnu.org; Sun, 21 Feb 2021 17:06:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDwrZ-0003U8-Sk for guix-patches@gnu.org; Sun, 21 Feb 2021 17:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lDwrZ-0003sf-OO for guix-patches@gnu.org; Sun, 21 Feb 2021 17:06:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46564] [PATCH core-updates]: Use autoconf-wrapper instead of autoconf Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Feb 2021 22:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46564 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 46564@debbugs.gnu.org Received: via spool by 46564-submit@debbugs.gnu.org id=B46564.161394512214872 (code B ref 46564); Sun, 21 Feb 2021 22:06:01 +0000 Received: (at 46564) by debbugs.gnu.org; 21 Feb 2021 22:05:22 +0000 Received: from localhost ([127.0.0.1]:55107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDwqw-0003ro-1v for submit@debbugs.gnu.org; Sun, 21 Feb 2021 17:05:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDwqu-0003ra-La for 46564@debbugs.gnu.org; Sun, 21 Feb 2021 17:05:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42409) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDwqo-000375-DP; Sun, 21 Feb 2021 17:05:14 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40386 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lDwqm-0007pA-L3; Sun, 21 Feb 2021 17:05:13 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87zh03dgty.fsf@telenet.be> Date: Sun, 21 Feb 2021 23:05:11 +0100 In-Reply-To: <87zh03dgty.fsf@telenet.be> (Maxime Devos's message of "Tue, 16 Feb 2021 19:10:17 +0100") Message-ID: <875z2lgjqg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.87 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 32FB81C540 X-Spam-Score: -2.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: ITItSTyYNcro Hi, Maxime Devos skribis: > This patch replaces autoconf with autoconf-wrapped in the native-inputs > almost everywhere (except for some packages in > gnu/packages/autotools.scm). As this would cause many rebuilds, this > patch targets the "core-updates" branch and not "master". OK. > A wine package has autoconf in the inputs instead of native-inputs, > I wonder if that's intentional or a bug? I left that package untouched > for now. I think that=E2=80=99s a bug. > Why this change? > > * consistency / reducing confusion: some packages use autoconf, some use > autoconf-wrapper, and there's no (to me) obvious reason why two variants > of autoconf should be used. > > * > > * some progress towards booting without /bin/sh > > Scenario I have in mind (untested): > > 1. boot a system that doesn't have /bin/sh > 2. decide to hack on guix (run git clone ...., cd $REPO) > 3. guix environment guix > 4. sh ./bootstrap (calls autoreconf -vfi) > 5. ./configure --localstatedir=3D/var > 6. more stuff > > Without this patch, step (5.) will fail without this patch because > the generated ./configure script refers to /bin/sh, which doesn't > exist. > > That said, there are some #!/bin/sh shebangs in the source code, > so there are some problems in (6.). Yeah, I=E2=80=99m not sure this is a worthy goal. > Why not? > > * =E2=80=98make dist=E2=80=99 will produce unusable tarballs > when in an environment from =E2=80=98guix environment PACKAGE=E2=80=99. > This should now be replaced with =E2=80=98guix environment PACKAGE --ad= -hoc > autoconf'. Yeah. I would be in favor of unifying things the other way around: using =E2=80=98autoconf=E2=80=99 instead of =E2=80=98autoconf-wrapper=E2=80= =99 everywhere. Since there=E2=80=99s the =E2=80=98patch-shebangs=E2=80=99 phase, we don=E2=80=99= t need =E2=80=98autoconf-wrapper=E2=80=99. There=E2=80=99s one exception I think: Automake. This one needs =E2=80=98autoconf-wrapper=E2=80=99 so it can actually run its test suite. = Perhaps Libtool too. WDYT? Ludo=E2=80=99.