unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Vinícius dos Santos Oliveira" <vini.ipsmaker@gmail.com>
Cc: 46231@debbugs.gnu.org
Subject: [bug#46231] Add emilua
Date: Mon, 22 Feb 2021 11:04:42 +0100	[thread overview]
Message-ID: <875z2kwh8l.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAK9RveLDBw3DVKz5tbKnPvShNFu2KYi8Sux-mrm_=oTDuiMQ2w@mail.gmail.com> ("Vinícius dos Santos Oliveira"'s message of "Sun, 21 Feb 2021 09:04:25 -0300")

Hello,

Vinícius dos Santos Oliveira <vini.ipsmaker@gmail.com> writes:

Thank you for your detailed answer! Some comments follow.

> I've used "define" instead "define-public" so it wouldn't be really
> available elsewhere in the system.

I know. But this does not prevent to choose an explicit name.

> However after some thought I do agree that this dependency can be
> generally useful to more people and should have a proper name.
>
> What do you think about the name openresty-luajit-lua52?

The trend in other distributions is to use luajit-openresty, in this
order. So maybe luajit-lua52-openresty? Or luajit-openresty if that is
unambiguous. It is not a big issue anyway.

>> - I see that emilua uses #:recursive? set to #true. Could some
>>   submodules could be unbundled by any chance?
>
> Some, yes, but not all. A Debian packager asked me the same and I
> already started to unbundle the dependencies where it can make sense
> to use the one found in the system. I can offer more details on why a
> few dependencies still must be provided as submodules if requested.
> Next emilua version (a couple of weeks away) should use more
> dependencies from the system and less bundled dependencies, but you'll
> still need #:recursive? set to #true for the bundled dependencies that
> will remain.

Then could you add a comment explaining what will be required, and what
can be removed later on (as a TODO)?

> I intend to solve this issue and I already started to investigate so
> it'll eventually be solved, but in the meantime I just disabled the
> tests. I don't control the paths the Lua VM generates so improving the
> AWK script is really my only choice here.

OK. Then could you add a short comment explaining the issue, and that it
is being worked on?

> Sure. Let's get the openresty-luajit-lua52 package in first and then
> I'll work on the second patch.

Great!

> Here's the patch for openresty-luajit-lua52 alone:
> https://gitlab.com/emilua/emilua/-/snippets/2079960

The version should be "2.1-20201027" and the commit (string-append "v"
version). Don't forget to remove the string-append in the description.
Also, the description itself is not particularly clear. Maybe

     This package provides the official OpenResty branch of LuaJIT.  It
     is not to be considered a fork, since changes are regularly
     synchronized from the upstream LuaJIT project.

Could you send this to this ML using git format-patch?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2021-02-22 10:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 10:00 [bug#46231] Add emilua Vinícius dos Santos Oliveira
2021-02-21  1:21 ` Nicolas Goaziou
2021-02-21 12:04   ` Vinícius dos Santos Oliveira
2021-02-22 10:04     ` Nicolas Goaziou [this message]
2021-02-23 20:35       ` Vinícius dos Santos Oliveira
2021-02-24 13:07         ` Nicolas Goaziou
2021-02-24 13:20           ` Vinícius dos Santos Oliveira
2021-02-24 15:49             ` Nicolas Goaziou
2021-02-25 14:11               ` Vinícius dos Santos Oliveira
2021-02-27 11:20                 ` bug#46231: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z2kwh8l.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=46231@debbugs.gnu.org \
    --cc=vini.ipsmaker@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).