From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 47392@debbugs.gnu.org
Subject: [bug#47392] [PATCH 0/2] Add Laminar.
Date: Fri, 09 Apr 2021 12:06:02 +0100 [thread overview]
Message-ID: <875z0v3eg5.fsf@cbaines.net> (raw)
In-Reply-To: <87mtuduk79.fsf_-_@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Christopher Baines <mail@cbaines.net> skribis:
>
>> * gnu/services/ci.scm: New file.
>> * gnu/tests/ci.scm: New file.
>> * doc/guix.texi (Laminar): Document the Laminar service.
>
> [...]
>
>> +@defvr {Scheme Procedure} laminar-service-type
>> +The type of the Laminar service. Its value must be a
>> +@code{laminar-configuration} object, as described below.
>> +@end defvr
>
> It would be nice to add a config example with one or two sentences
> explaining what it does.
Sure, I've added an example now, albeit the simplest one.
>> + #:export (<laminar-configuration>
>
> Please don’t export the record type descriptor.
I removed this.
> Otherwise LGTM, thanks!
Cool, I've pushed this as eda4bb4f16f74436b0caf1c584888c89b3c4c69b now.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2021-04-09 11:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 15:23 [bug#47392] [PATCH 0/2] Add Laminar Christopher Baines
2021-03-25 15:26 ` [bug#47392] [PATCH 1/2] gnu: Add laminar Christopher Baines
2021-03-25 15:26 ` [bug#47392] [PATCH 2/2] services: Add Laminar Christopher Baines
2021-04-05 9:58 ` [bug#47392] [PATCH 0/2] " Ludovic Courtès
2021-04-09 11:06 ` Christopher Baines [this message]
2021-04-05 9:56 ` Ludovic Courtès
2021-04-07 6:35 ` Lars-Dominik Braun
2021-04-09 11:09 ` Christopher Baines
2021-04-09 11:06 ` bug#47392: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z0v3eg5.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=47392@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).