From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gO8fKpTKk2DLHgEAgWs5BA (envelope-from ) for ; Thu, 06 May 2021 12:53:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 8Ay6JZTKk2BpVwAAB5/wlQ (envelope-from ) for ; Thu, 06 May 2021 10:53:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 584051BC39 for ; Thu, 6 May 2021 12:53:08 +0200 (CEST) Received: from localhost ([::1]:45612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lebcx-0001SB-Hc for larch@yhetil.org; Thu, 06 May 2021 06:53:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lebct-0001RS-Ey for guix-patches@gnu.org; Thu, 06 May 2021 06:53:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54050) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lebct-0000SF-7r for guix-patches@gnu.org; Thu, 06 May 2021 06:53:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lebct-0002j7-6S for guix-patches@gnu.org; Thu, 06 May 2021 06:53:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47824] [PATCH 0/3] Happy hacking in the Spring 2021 LGJ Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 May 2021 10:53:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47824 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: 47824@debbugs.gnu.org, efraim@flashner.co.il Received: via spool by 47824-submit@debbugs.gnu.org id=B47824.162029836810459 (code B ref 47824); Thu, 06 May 2021 10:53:03 +0000 Received: (at 47824) by debbugs.gnu.org; 6 May 2021 10:52:48 +0000 Received: from localhost ([127.0.0.1]:37361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebce-0002id-Jy for submit@debbugs.gnu.org; Thu, 06 May 2021 06:52:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebcd-0002iX-BM for 47824@debbugs.gnu.org; Thu, 06 May 2021 06:52:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57482) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lebcW-0000B1-Ll; Thu, 06 May 2021 06:52:40 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60876 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1lebcW-00062e-Ef; Thu, 06 May 2021 06:52:40 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210419081744.7247-1-leo.prikler@student.tugraz.at> <20210419081744.7247-3-leo.prikler@student.tugraz.at> <874kfhjmfd.fsf_-_@gnu.org> <867322166b5492fe1964df02db2b4d148ade29dd.camel@student.tugraz.at> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 =?UTF-8?Q?Flor=C3=A9al?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 06 May 2021 12:52:39 +0200 In-Reply-To: <867322166b5492fe1964df02db2b4d148ade29dd.camel@student.tugraz.at> (Leo Prikler's message of "Wed, 05 May 2021 17:00:05 +0200") Message-ID: <875yzwgmmg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620298388; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=+kwSJi119dSPn9nGumgLEMNK4veDfnZ2Lw5pgIV5nM8=; b=kO9senwYAr7qJLnwPFSlhGXaAmn1lfuW8YSY4ThC6SzPFEciTi1/1eU5Hj22DGrQ9Hmx0v 7X+K3x1zIgUc+EK3l7YSZ7B+UEt8SoO6VNLbf8qNCLoFRs8udCT6e6qZ3RG0BBopgJG7r6 8Q7t+ceU9YqRAZ/LxMq2+EKvtx4RgSxeoT1lefJWFBqWrqOkUXKDIEgIoItEeQ1U4z2QyJ JXRmp7ya5+IwjW4t3q5o/Lc7Zb/0cUITznSIMHPG5FtWQGVaZhFFM/53EPbL562qxQjwS3 aG0rlPCniTi6O6DcHjw+SBe7JMILThiqnm5l+Rf3VlrugIz3W1OnAxjDGpHXlg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620298388; a=rsa-sha256; cv=none; b=BtPLCnV2ny3IbMyats08a16JS7eIKDOfnDnrN/Ri9RNCJPHAmCITrEl5zY1l9BfNW5CeAu asQEC3ZKZioxoRfzHdvOyC9RnixMPdhY7vn4ldB7gGvS62zX0e6OmlrdgnpCOh6HvNlfAi 4pv6UYosDSLwmM3WQ1jYr1OQLbHvteN4mlbLKx2uKVrdZfH0K/UMTJlls2YoKjMUDMhnuw 7xKSnj/5lyX34EHzcDxlsX8Qn/ENmJGzysiU4vPt9G2ySAQRpTSPs5nvloGRvTLQ0Yeb+g /58xhj10Gqe8rYk3BAIL6G0lsDEo+dFkBxKmIWl47Dhyw8EG3zVI+pkxxk8uCw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.46 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 584051BC39 X-Spam-Score: -1.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: Q77+VryUYBeI Hi, Leo Prikler skribis: > Am Mittwoch, den 05.05.2021, 16:16 +0200 schrieb Ludovic Court=C3=A8s: >> Hi Leo, >>=20 >> On a cursory look, all three patches LGTM. >>=20 >> One nit: >>=20 >> > + "exec " >> > + (assoc-ref inputs "guile-runtime") >> > + "/bin/guile " args))) >>=20 >> [...] >>=20 >> > ("guile" ,guile-3.0) >> > ("pkg-config" ,pkg-config) >> > ("texinfo" ,texinfo))) >> > - (propagated-inputs >> > - `(("guile-sdl2" ,guile3.0-sdl2))) >> > + (inputs >> > + `(("guile-sdl2" ,guile3.0-sdl2) >> > + ("guile-runtime" ,guile-3.0))) >>=20 >> I think it=E2=80=99s best to not play trick with labels, and to always u= se >> the >> package name as the label (to facilitate migration on the day where >> we >> get rid of labels, who knows=E2=80=A6). >>=20 >> A common pattern for the case above is to provide =E2=80=9Cguile=E2=80= =9D both as >> native >> input and input, and to write: >>=20 >> (assoc-ref (or native-inputs inputs) "guile") > What I'm doing here is the exact opposite. I don't want the > omnipresent native-input guile to shadow the guile I use as input, In that case, you can unconditionally do: (assoc-ref inputs "guile") Unless I=E2=80=99m mistaken, it won=E2=80=99t be shadowed by the native inp= ut =E2=80=9Cguile=E2=80=9D when cross-compiling. Or am I missing something? Ludo=E2=80=99.