From: "Ludovic Courtès" <ludo@gnu.org>
To: Michael Rohleder <mike@rohleder.de>
Cc: 48194@debbugs.gnu.org
Subject: [bug#48194] [PATCH] gnu: libmediainfo: Fix usage of libcurl and libtinyxml2.
Date: Sun, 06 Jun 2021 15:17:09 +0200 [thread overview]
Message-ID: <875yyrku96.fsf_-_@gnu.org> (raw)
In-Reply-To: <87v97pzc41.fsf@gnu.org> ("Ludovic Courtès"'s message of "Tue, 11 May 2021 14:30:38 +0200")
Ping! :-)
Ludovic Courtès <ludo@gnu.org> skribis:
> Michael Rohleder <mike@rohleder.de> skribis:
>
>>>>From 6612d1189263cc4670b820e26f5e75d4df9c68b0 Mon Sep 17 00:00:00 2001
>> From: Michael Rohleder <mike@rohleder.de>
>> Date: Tue, 11 May 2021 14:05:13 +0200
>> Subject: [PATCH] gnu: mediainfo: Fix usage of libcurl and tinyxml2.
>>
>> * gnu/packages/video.scm (mediainfo): Fix usage of libcurl and tinyxml2.
>
> Please mention [arguments] and [propagated-inputs].
>
>
>> gnu/packages/video.scm | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
>> index 481ab46b6e..630edf49b6 100644
>> --- a/gnu/packages/video.scm
>> +++ b/gnu/packages/video.scm
>> @@ -3834,6 +3834,8 @@ practically any type of media.")
>> (build-system gnu-build-system)
>> (arguments
>> '(#:tests? #f ; see above TODO
>> + #:configure-flags
>> + (list "--with-libcurl" "--with-libtinyxml2")
>> #:phases
>> ;; build scripts not in root of archive
>> (modify-phases %standard-phases
>> @@ -3888,6 +3890,8 @@ MPEG-2, MPEG-4, DVD (VOB)...
>> ("libtool" ,libtool)
>> ("pkg-config" ,pkg-config)
>> ("zlib" ,zlib)
>> + ("curl" ,curl) ;; In Requires.private of libmediainfo pkg-config files.
>> + ("tinyxml2" ,tinyxml2)
>
> Shouldn’t we also remove them from ‘native-inputs’, which looks bogus
> anyway?
>
> Thanks,
> Ludo’.
next prev parent reply other threads:[~2021-06-06 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 15:20 [bug#48194] [PATCH] gnu: libmediainfo: Fix usage of libcurl and libtinyxml2 Michael Rohleder
2021-05-11 10:31 ` bug#48194: " Ludovic Courtès
2021-05-11 10:51 ` [bug#48194] " Ludovic Courtès
2021-05-11 12:14 ` Michael Rohleder
2021-05-11 12:30 ` Ludovic Courtès
2021-06-06 13:17 ` Ludovic Courtès [this message]
2021-06-09 6:27 ` Michael Rohleder
2021-06-11 22:40 ` bug#48194: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yyrku96.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=48194@debbugs.gnu.org \
--cc=mike@rohleder.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).