unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: Thorsten Wilms <t_w_@freenet.de>, 49028@debbugs.gnu.org
Cc: Thorsten Wilms <t_w_@freenet.de>
Subject: [bug#49028] [PATCH] gnu: Add mda-lv2
Date: Fri, 18 Jun 2021 16:36:18 +0200	[thread overview]
Message-ID: <875yyb6xzx.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20210614193224.9902-1-t_w_@freenet.de>

[-- Attachment #1: Type: text/plain, Size: 1830 bytes --]

On Mon, Jun 14 2021, Thorsten Wilms wrote:

> +(define-public mda-lv2
> +  (package
> +   (name "mda-lv2")
> +   (version "1.2.6")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri
> +      ;; Tarball from gitlab lacks waflib directory content, so take it from
> +      ;; drobilla.net.
> +      (string-append "http://download.drobilla.net/mda-lv2-"
> +		     version ".tar.bz2"))

The waflib directory is a submodule in the Git repo, something like this
should work (untested):

  (git-reference
    (url "https://gitlab.com/drobilla/mda-lv2")
    (commit (string-append "v" version))
    (recursive? #t))
  
> +     (sha256
> +      (base32 "1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
> +   (build-system waf-build-system)
> +   (arguments
> +    `(#:tests? #f  ; There are no tests.
> +      #:configure-flags
> +      (list (string-append "--prefix="
> +			   (assoc-ref %outputs "out")))))
> +   (inputs
> +    `(("lv2" ,lv2)))
> +   (native-inputs
> +    `(("pkg-config" ,pkg-config)))
> +   (native-search-paths
> +    (list (search-path-specification
> +           (variable "LV2_PATH")
> +           (files '("lib/lv2")))))
> +   (home-page "https://drobilla.net/software/mda-lv2")
> +   (synopsis "Audio plug-in pack for LV2")
> +   (description
> +    "A port of the MDA VST plugins to LV2. Includes effects and a few
> +instruments.")

The description should consist of one or more full sentences, and use
double spaces between sentences.  Maybe something like this:

  MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and
  a few instrument plugins.
  
> +   (license (list license:gpl3+ license:gpl3+))))

The two licenses are the same, simply ‘license:gpl3+’ would do.

Could you send an updated patch?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-06-18 14:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 19:32 [bug#49028] [PATCH] gnu: Add mda-lv2 Thorsten Wilms
2021-06-18 14:36 ` Xinglu Chen [this message]
2021-06-20 14:26 ` Thorsten Wilms
2021-06-22  7:44   ` Xinglu Chen
2021-06-22 11:00     ` [bug#49028] [PATCH v3] Add mda-lv2. * gnu/packages/audio.scm (mda-lv2): New variable Thorsten Wilms
2021-06-23  8:46       ` Xinglu Chen
2021-06-28 14:49       ` bug#49028: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yyb6xzx.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=49028@debbugs.gnu.org \
    --cc=t_w_@freenet.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).