From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WJbKD9iV3WF+DAEAgWs5BA (envelope-from ) for ; Tue, 11 Jan 2022 15:36:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yH1/CNiV3WGptAAAG6o9tA (envelope-from ) for ; Tue, 11 Jan 2022 15:36:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B2B1711C6A for ; Tue, 11 Jan 2022 15:36:03 +0100 (CET) Received: from localhost ([::1]:56734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7IFm-0006Pu-PU for larch@yhetil.org; Tue, 11 Jan 2022 09:36:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7GxW-0004Ng-Ej for guix-patches@gnu.org; Tue, 11 Jan 2022 08:13:09 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33283) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7GwU-0007hp-GC for guix-patches@gnu.org; Tue, 11 Jan 2022 08:12:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7GwU-0003ML-CY for guix-patches@gnu.org; Tue, 11 Jan 2022 08:12:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52866] maintenance: Add a crash dump service. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 Jan 2022 13:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52866 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: 52866@debbugs.gnu.org Received: via spool by 52866-submit@debbugs.gnu.org id=B52866.164190666912829 (code B ref 52866); Tue, 11 Jan 2022 13:12:02 +0000 Received: (at 52866) by debbugs.gnu.org; 11 Jan 2022 13:11:09 +0000 Received: from localhost ([127.0.0.1]:54419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7Gvd-0003Kr-5O for submit@debbugs.gnu.org; Tue, 11 Jan 2022 08:11:09 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:50588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7GvY-0003KE-MM for 52866@debbugs.gnu.org; Tue, 11 Jan 2022 08:11:08 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C082B5FE; Tue, 11 Jan 2022 14:10:58 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n4UKpLow3EH2; Tue, 11 Jan 2022 14:10:57 +0100 (CET) Received: from ribbon (unknown [193.50.110.156]) by hera.aquilenet.fr (Postfix) with ESMTPSA id E380B182; Tue, 11 Jan 2022 14:10:56 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <878rw3ixey.fsf@gnu.org> <87v8yxj37p.fsf@gnu.org> <871r1lw9wx.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 =?UTF-8?Q?Niv=C3=B4se?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 11 Jan 2022 14:10:56 +0100 In-Reply-To: <871r1lw9wx.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 06 Jan 2022 09:22:38 +0100") Message-ID: <875yqqv2n3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: C082B5FE X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641911763; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=fMWA6Eyg5o653+VT/p+ZOcyqH2Kc0yiesGiJS5QWSVU=; b=n9JoQZ3k7WpAXdeLvkR8WPisUmujEUSSa/Dh5nN/bTQWkxRYiE0vEO7NQaTE306naBL2Ty XWkCTxS8yZ2tQaeBv0s8Lm6gq4kiDaC1F948Iy6cus7wHk4zfZ6eg4oA+hgsvAqHw4fY6X jqK9GTcK/xtmdNbjZAWH+ONLedK8V9eJHHCJFDQXL6v2X4L3k4cCNe1D3ZtxWcjO5+OAVD qJ1SHLI/ggb+TrLsfNDjQ6LICFUczLQJDd6liol9PKP+iO9mA0ompNokFOX8VUNmu/V/g2 ImIdhIeXi/mNpb/pNcM2/K24w4URFc5HZiIua49C1HbnApsTQsN2cW6XRIrb9w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641911763; a=rsa-sha256; cv=none; b=O8jsBABq32lWMTTsvHreyiGiEFOJU50Sj1s/HG/3y2N0SgFaNf7W5LzVzrB5Jn5q4/NzEj j+hGoZ41b6fiVtBvbMoPcKB5X3lGasiheSF9U0A/2ICj33UiYHXM1GlpngFkCM0HYoxjJJ lfdIly9b/Y8pEoouquDmu755uvn9PobXhP2LH08jsRqbiMdAtSHAtr0clkrqbvLar/7XAN 5Y7SJJ50vintwOiVyuz6AQZAcQhYBYOa3lQILkOmKg3a9LK789APpnmgCu2npjiGpnhcVO FTp86VoOnF8rBYfD5Pw4Ao6UFZ80efnEdr9U6Oi7PMCoXpy3BKexXcJ26pT6oQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B2B1711C6A X-Spam-Score: -3.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9Xk3Q39rX02M Hi, Mathieu Othacehe skribis: >> Or, dump.guix.gnu.org could relay everything as-is to bug-guix@gnu.org >> *if* we know users are aware of what data is being reported. > > That's something that also crossed my mind, but I chose instead to make > the web-server publish the bug reports here: https://dump.guix.gnu.org. > They can then be downloaded with this URL: > https://dump.guix.gnu.org/download/. > > Of course the next step it to use this API in a command line tool or > so. I don't feel like working on another web interface. OK (I didn=E2=80=99t know it was already deployed!). What if we just put t= he uploaded file in a directory and let nginx provide a directory index and all? Anyway, given the target audience, it doesn=E2=80=99t have to be fanc= y. :-) > Regarding the installer integration, you can have a look to: > https://git.savannah.gnu.org/cgit/guix.git/commit/?h=3Dwip-harden-install= er&id=3D22158d407af89d2f3df3abd8005ec2321df45c74. At first sight it LGTM. The key thing is that the crash dump code must be programmed =E2=80=9Cdefensively=E2=80=9D so that it never crashes itself= ; it should gracefully handle transient network errors, TLS certificate issues, bad HTTP responses, etc., and just say it when it failed to upload the report. > There's already a window asking before uploading the crash dump. I think > that if we make the warning message even more explicit it could be fine. The message should allow for informed consent. Thus it should explain what the risks are (=E2=80=9CLogs may contain sensitive information such as= =E2=80=A6=E2=80=9D, =E2=80=9CLogs are eventually publicly visible, but IP addresses are not log= ged=E2=80=9D, etc.) and/or it should let users screen all the logs. Josselin Poiret skribis: > While looking at the code for the crash dump page in the installer, I > didn't see any special handling of user and root passwords. I've just > tested it at https://dump.guix.gnu.org/download/installer-dump-c9deb88f, > and you can see that the passwords end up in the results at the end > (both are `TEST` in capitals in my case). I think this might require > more thought. I'm not sure we have to include the result alist in the > dump report, as the installer log should provide enough information in > the case of a failure. As discussed the other day on IRC, to make sure the backtrace does not contain passwords, we could define a record type for =E2=80=9Csecrets=E2=80= =9D, which would basically just =E2=80=9Cbox=E2=80=9D strings such as passwords. That= record type=E2=80=99s printer would just print #. See for an example. > Concerning Ludo's objection to syslog being in the dump, this was one of > the reasons behind the new logging facilities at [1], which provide a > clean installer-only log file. We could add some checkboxes to choose > which files to include, eg: > > [X] Installer log > [ ] Syslog > [ ] Dmesg > > Along with an option to view them in a pager. Problem is that users, even advanced users, cannot necessarily tell what sensitive info each of these might contain, nor whether withdrawing them from the report would impede debugging. So it=E2=80=99s probably a choice = we have to make ourselves. Since the installer uses syslog, we could add a syslog rule that redirects installer logging to a separate file. We still need kernel output to see info about devices, but perhaps that too could go to a separate file? Thanks, Ludo=E2=80=99.