unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#52891] [PATCH] guix-install.sh: Run guix.sh script in /etc/profile.d last.
@ 2021-12-30  8:39 Konrad Hinsen
  2022-01-14  8:27 ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Konrad Hinsen @ 2021-12-30  8:39 UTC (permalink / raw)
  To: 52891

* etc/guix-install.sh: Rename /etc/profile.d/guix.sh to zzz-guix.sh.

This script refers to environment variables set by the host distribution.
They may be set in other scripts in /etc/profile.d, which must therefore
be run first.
Example: in Ubuntu 20.04, XDG_DATA_DIRS is set in
/etc/profile.d/xdg_dirs_desktop_session.sh
---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index cd1a1c34c1..00a9fc5377 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -503,7 +503,7 @@ sys_create_init_profile()
 { # Define for better desktop integration
   # This will not take effect until the next shell or desktop session!
     [ -d "/etc/profile.d" ] || mkdir /etc/profile.d # Just in case
-    cat <<"EOF" > /etc/profile.d/guix.sh
+    cat <<"EOF" > /etc/profile.d/zzz-guix.sh
 # _GUIX_PROFILE: `guix pull` profile
 _GUIX_PROFILE="$HOME/.config/guix/current"
 export PATH="$_GUIX_PROFILE/bin${PATH:+:}$PATH"
-- 
2.34.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#52891] [PATCH] guix-install.sh: Run guix.sh script in /etc/profile.d last.
  2021-12-30  8:39 [bug#52891] [PATCH] guix-install.sh: Run guix.sh script in /etc/profile.d last Konrad Hinsen
@ 2022-01-14  8:27 ` Ludovic Courtès
  2022-11-08  9:58   ` bug#52891: " Mathieu Othacehe
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2022-01-14  8:27 UTC (permalink / raw)
  To: Konrad Hinsen; +Cc: 52891

Hi Konrad,

Konrad Hinsen <konrad.hinsen@fastmail.net> skribis:

> * etc/guix-install.sh: Rename /etc/profile.d/guix.sh to zzz-guix.sh.
>
> This script refers to environment variables set by the host distribution.
> They may be set in other scripts in /etc/profile.d, which must therefore
> be run first.
> Example: in Ubuntu 20.04, XDG_DATA_DIRS is set in
> /etc/profile.d/xdg_dirs_desktop_session.sh

[...]

> -    cat <<"EOF" > /etc/profile.d/guix.sh
> +    cat <<"EOF" > /etc/profile.d/zzz-guix.sh

Does anybody have objections, such as distros where this would not work?

Otherwise let’s apply it in time for the upcoming release.

Thanks,
Ludo’.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#52891: [PATCH] guix-install.sh: Run guix.sh script in /etc/profile.d last.
  2022-01-14  8:27 ` Ludovic Courtès
@ 2022-11-08  9:58   ` Mathieu Othacehe
  0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Othacehe @ 2022-11-08  9:58 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: Konrad Hinsen, 52891-done


Hello,

> Does anybody have objections, such as distros where this would not work?
>
> Otherwise let’s apply it in time for the upcoming release.

Tested on Ubuntu, seems to work fine. It appears to be the right thing
to do to make sure that Guix stuff is prepended to XDG_*, PATH and
INFOPATH variables.

Applied as 93be56a3ab28ed0a482f354b7f536681c99b6999.

Thanks,

Mathieu




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-08 10:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-30  8:39 [bug#52891] [PATCH] guix-install.sh: Run guix.sh script in /etc/profile.d last Konrad Hinsen
2022-01-14  8:27 ` Ludovic Courtès
2022-11-08  9:58   ` bug#52891: " Mathieu Othacehe

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).