unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 52832@debbugs.gnu.org
Subject: [bug#52832] [PATCH 1/3] gnu: Add android-platform-frameworks-native-headers.
Date: Sat, 15 Jan 2022 22:36:34 +0100	[thread overview]
Message-ID: <875yqk3cm5.fsf_-_@gnu.org> (raw)
In-Reply-To: <d9c2d29ae4dcb8dbff5e727173b09cb4af21cf2f.1640635865.git.h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Mon, 27 Dec 2021 21:15:05 +0100")

Hi,

Some late comments:

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> * gnu/packages/android.scm (android-platform-development, etc1tools):
>   New variables.

[...]

> +         (add-before 'build 'fix-typos-in-help
> +           (lambda _
> +             (substitute* "tools/etc1tool/etc1tool.cpp"
> +               ((" apropriate ") " appropriate "))
> +             #t))

You can now omit trailing #t (yay!).

> +    (inputs
> +     `(("libetc1" ,libetc1)
> +       ("libpng" ,libpng)))

Make sure to run ‘./pre-inst-env guix style -S inputs’ on your packages.

> +    (synopsis "Encode and decode PNG images to resp. from the ETC1 compression
> +standard.")

Please follow the guidelines and ‘guix lint’ warnings.

Thanks,
Ludo’.




      parent reply	other threads:[~2022-01-15 21:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-27 20:11 [bug#52832] [PATCH 1/3] gnu: Add android-platform-frameworks-native-headers Hartmut Goebel
2021-12-27 20:15 ` [bug#52832] [PATCH 2/3] gnu: Add libetc1 Hartmut Goebel
2021-12-27 20:15 ` [bug#52832] [PATCH 3/3] gnu: Add etc1tool Hartmut Goebel
2022-01-15 20:22   ` Hartmut Goebel
2022-01-15 21:36   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yqk3cm5.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=52832@debbugs.gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).