unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 49820-done@debbugs.gnu.org, Martin Becze <mjbecze@riseup.net>
Subject: bug#49820: [PATCH] gnu: texlive-bin: Add patch files to repo.
Date: Wed, 02 Feb 2022 21:56:26 -0500	[thread overview]
Message-ID: <875ypw4q05.fsf@gmail.com> (raw)
In-Reply-To: <878rut9lxs.fsf_-_@gmail.com> (zimoun's message of "Wed, 02 Feb 2022 19:13:03 +0100")

Hi Simon,

zimoun <zimon.toutoune@gmail.com> writes:

> Hi,
>
> On Tue, 03 Aug 2021 at 14:56, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>> Martin Becze <mjbecze@riseup.net> writes:
>>
>>> This adds two patch files that used to be hosted by the arch linux community
>>> but was recently moved.
>>>
>>> * gnu/packages/patches/texlive-poppler-0.84.patch: New file.
>>> * gnu/packages/patches/pdftex-poppler0.76.patch: New file.
>>> * gnu/packages/tex.scm (texlive-bin): Changed to use local patch files.
>
> [...]
>
>> I'm afraid this can't go to master as 'guix refresh -l texlive-bin' says
>> 5160 packages would need to be rebuilt.  It's also not needed for
>> core-updates as it contains TeX Live 2021 which doesn't need these
>> patches anymore.
>
> Indeed, but sadly we overlooked at the issue raised by this patch; not
> the patch themselves, the move of Arch to another hosting system.
>
> The consequence is many time-machine are now broken, for instance:
>
>     $ guix time-machine --commit=e77412362f -- help
>
> sha256 hash mismatch for /gnu/store/7c5jx9zbnh8nlapbxqv1wl8056lhhl2l-texlive-bin-pdftex-poppler0.75.patch:
>   expected hash: 1cqpcp7h1qyxyp3wjbpcmx2wgvj9ywpz60hvy280mp9w633yzyg3
>   actual hash:   0ribvsg4bka1cyj1wz4cd6vrxkvhqvlmjr75d7fdz5pw9r3rlgk8
> hash mismatch for store item '/gnu/store/7c5jx9zbnh8nlapbxqv1wl8056lhhl2l-texlive-bin-pdftex-poppler0.75.patch'
>
>
> because this kind of snippet:
>
>        (let ((arch-patch
>               (lambda (name revision hash)
>                 (origin
>                   (method url-fetch)
>                   (uri (string-append "https://git.archlinux.org/svntogit/packages.git"
>                                       "/plain/trunk/" name "?h=packages/texlive-bin"
>                                       "&id=" revision))
>                   (file-name (string-append "texlive-bin-" name))
>                   (sha256 (base32 hash)))))
>              (arch-revision "418dd6f008c3d41a461353fdb60f2d73d87c58ed"))
>          (append (search-patches  "texlive-bin-CVE-2018-17407.patch"
>                                   "texlive-bin-luatex-poppler-compat.patch")
>                  (list
>                   (arch-patch "pdftex-poppler0.75.patch" arch-revision
>                               "1cqpcp7h1qyxyp3wjbpcmx2wgvj9ywpz60hvy280mp9w633yzyg3")
>
> Another story!
>
>
> Well, I think this patch proposal for master can be closed.  WDYT?

Yes!

Thanks for your efforts in tidying the house :-).

Closing for now.

Maxim




      reply	other threads:[~2022-02-03  2:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  9:36 [bug#49820] [PATCH] gnu: texlive-bin: Add patch files to repo Martin Becze
2021-08-03 18:56 ` Maxim Cournoyer
2022-02-02 18:13   ` zimoun
2022-02-03  2:56     ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ypw4q05.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=49820-done@debbugs.gnu.org \
    --cc=mjbecze@riseup.net \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).