unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Guillaume Le Vaillant <glv@posteo.net>
To: Trevor Richards <trev@trevdev.ca>
Cc: 57757@debbugs.gnu.org
Subject: [bug#57757] [PATCH] gnu: Add sbcl-stumpwm-pamixer
Date: Fri, 16 Sep 2022 07:50:18 +0000	[thread overview]
Message-ID: <875yhnrbml.fsf@kitej> (raw)
In-Reply-To: <ffcb7e876354b99698a9d0866ed4337a00678ac8.1663273983.git.trev@trevdev.ca>

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

Trevor Richards <trev@trevdev.ca> skribis:

> ---
>  gnu/packages/wm.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 451dfce516..3f2258db52 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -1986,6 +1986,31 @@ (define-public stumpish
>      (description "This package provides a StumpWM interactive shell.")
>      (license (list license:gpl2+ license:gpl3+ license:bsd-2))))
>  
> +(define-public sbcl-stumpwm-pamixer
> [...]
> +      (inputs `(("stumpwm" ,stumpwm "lib")))
> +      (propagated-inputs (list pamixer))
> [...]

Hi.

Instead of propagating pamixer, it would be better to put pamixer in
'inputs' and fix the path to the pamixer program in the 'run' function
in "pamixer.lisp". For example, take a look at the 'fix-paths' phase of
the sbcl-trivial-clipboard package.

Could you send an updated patch?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2022-09-16  8:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12 21:41 [bug#57757] [PATCH] * gnu/packages/wm.scm: Add sbcl-stumpwm-pamixer Trevor Richards
2022-09-12 21:41 ` [bug#57757] [PATCH] gnu: " Trevor Richards
2022-09-12 21:41 ` Trevor Richards
2022-09-16  7:50   ` Guillaume Le Vaillant [this message]
2022-09-16  9:07 ` [bug#57757] [PATCH] * gnu/packages/wm.scm: " Maxime Devos
2022-09-19 14:31   ` Trev
2022-09-19 16:17     ` Maxime Devos
2022-09-19 17:29       ` Trev
2022-09-19 17:47 ` [bug#57757] [PATCH] gnu: " Trevor Richards
2022-09-19 18:05   ` Maxime Devos
2022-09-19 18:22     ` Trev
2022-09-19 18:33       ` Maxime Devos
2022-09-19 21:34         ` Trev
2022-09-20  4:38           ` Trevor Richards
2022-09-20  7:17             ` bug#57757: " Guillaume Le Vaillant
2022-09-22 19:08           ` [bug#57757] " Maxime Devos
2022-09-22 20:35             ` Trev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yhnrbml.fsf@kitej \
    --to=glv@posteo.net \
    --cc=57757@debbugs.gnu.org \
    --cc=trev@trevdev.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).