From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EGvmOUHrrWOmDAAAbAwnHQ (envelope-from ) for ; Thu, 29 Dec 2022 20:32:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qMcQOUHrrWMxpAAAG6o9tA (envelope-from ) for ; Thu, 29 Dec 2022 20:32:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0FDBB462 for ; Thu, 29 Dec 2022 20:32:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAydJ-0002gx-NT; Thu, 29 Dec 2022 14:32:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAydG-0002gW-Q2 for guix-patches@gnu.org; Thu, 29 Dec 2022 14:32:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAydG-0004gx-E1 for guix-patches@gnu.org; Thu, 29 Dec 2022 14:32:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAydF-0003GE-S7 for guix-patches@gnu.org; Thu, 29 Dec 2022 14:32:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60224] [PATCH 0/9] Improvements to our u-boot tooling References: <20221220165038.25114-1-maxim.cournoyer@gmail.com> In-Reply-To: <20221220165038.25114-1-maxim.cournoyer@gmail.com> Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 29 Dec 2022 19:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60224 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60224@debbugs.gnu.org Received: via spool by 60224-submit@debbugs.gnu.org id=B60224.167234229412494 (code B ref 60224); Thu, 29 Dec 2022 19:32:01 +0000 Received: (at 60224) by debbugs.gnu.org; 29 Dec 2022 19:31:34 +0000 Received: from localhost ([127.0.0.1]:32932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAyco-0003FS-40 for submit@debbugs.gnu.org; Thu, 29 Dec 2022 14:31:34 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAycl-0003FI-LE for 60224@debbugs.gnu.org; Thu, 29 Dec 2022 14:31:32 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1672342288; cv=none; d=zohomail.com; s=zohoarc; b=GAfN3Aa0C8hFDHx2SSDlMuzCdp4AzJpRks2ixK6PYuifAX9K3TAgp6vGwTAdL/Zoa3uhZb1FAmdsnXy6bvs9/FYXpyLcKhBN0pC8qeW2s6nUPzB5NX0tUSnVKLoDmxPczoq6VUNvtnQ+LEDwqBZSli/wj6tk6VKcwp60Y3GEZL0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672342288; h=Content-Type:Content-Transfer-Encoding:Date:From:MIME-Version:Message-ID:Subject:To; bh=oCgCA8EbJysi172w/JI+04+4z7w/5KlCyl9zQberwL8=; b=dIZ9qcYZhBAkrJgnjMkTHw6zJ6t5PMd8EvKAFUmPdfhmRKC/6n7HLwDXpRTSjMkGeXT5s/1ZbbtmAfip17WpUb0+QoRGqSvsXw4GwSTQGzb+hstbZtDPKSbja5XOBAjFUS78eMIE/jUFnNPLvoEDptUd6Pnwu3fkXJZzkdR3f28= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1672342288; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=oCgCA8EbJysi172w/JI+04+4z7w/5KlCyl9zQberwL8=; b=NMWLd1jztASVWyAHKxOTFF3F8d3i/mFAYSdyK7jyR3ttf43IsmR94/hAt30C0VIJ kZc/g9uudPb5mSSP5XdQLO4MyIT0vKv8fQvUX7P/Baqht31FcTTthppyZ0W+dDQzFa9 8SpghFwCYIzXixaP7DhfU9DG/msICNdOhOWNPIts= Received: from localhost (1-108-142-46.pool.kielnet.net [46.142.108.1]) by mx.zohomail.com with SMTPS id 1672342288359792.899864027087; Thu, 29 Dec 2022 11:31:28 -0800 (PST) User-agent: mu4e 1.8.13; emacs 28.2 From: Ricardo Wurmus Date: Thu, 29 Dec 2022 20:18:57 +0100 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <875ydu9fch.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=2; s=key1; d=yhetil.org; t=1672342337; a=rsa-sha256; cv=fail; b=G8OdYBpTbLx+pPV/yghtZG84lyjpVegby2cqVq2VupCb4QY++d+iKTB2rvWnxT3unKbDCd PCJlC0UuKgye9ruBWgvTEiNza/SmqUFAWLBpgSZexo+c70JwVtfunT9J3EPueMUKVL5SjI axnKWh35rHOEaFEPrKzdOnzAXA3s2JxVQNoPi/VYN52b/xBBaUe1tgAFtSRjVZIXhiOILg j92saRG60Gy+A71iipYvbv6bJlw5HO7OmdV+cT0wf7F5gqQ8aVuPlZ8XdJ2Ky/fyFUB3ZE mGjq3oN8QC+X3xNFPn+Cxjge2fBO1y8Rz1fCb6sgpsaMky7bxR8GftwTs+73Pw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=NMWLd1jz; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672342337; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oCgCA8EbJysi172w/JI+04+4z7w/5KlCyl9zQberwL8=; b=b3EvA71J5lq70HXq/oAryKTdI7avIujzi9owYLRNTngez+315NVBYpd+OqfX0Z0vGVmIvt aDzpcG5zi09g3rcbHtbvuDMZ9P0muevfJ9qYOKLHOc2I6tUyW1dOwAvqtfQVX1ecGgAz/c UuOQh5NmwYpAMd3FKtFsrp/ORrANadl3JvmMn6dTAeFeK5fC79WhfJrHorMf2S7cxlfg+B 9yl3k9kuThKlN5gL8MGwoMGg9/NlEPxw2pRL4QYtMXwrMxCHrnTzLjDXlXv03OM9wovXUg 37DepWYg5vMce1LPU6+nMRlBcAgoFucmXsH2vI6GdiEUvJKEu3kwTTPOvwBqXw== X-Spam-Score: -0.13 X-Migadu-Queue-Id: 0FDBB462 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=NMWLd1jz; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}") X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -0.13 X-TUID: kClacpNgmIRl Hi Maxim, this looks reasonable to me. Some comments below. A minor comment about the first patch: you still bind =E2=80=9Coutputs=E2= =80=9D in the build phases, but since you=E2=80=99re using #$output anyway this value is = never used. [PATCH 3/9] introduces a comment in the definition of =E2=80=9Cnative-build= ?=E2=80=9D, which references %current-target-system, yet only %current-system is used. Is this a mistake? [PATCH 4/9] =E2=80=94 This one appends arm-trusted-firmware-rk3399 instead = of prepending it. This differs from how it was done with the labeled inputs. Does this have any consequences? Is the =E2=80=9Cfirmware=E2=80= =9D label used anywhere (such as downstream packages)? The same applies to patches 5/9, 7/9, and 8/9. [PATCH 6/9] =E2=80=94 The change from .bin to .elf confuses me. Is this du= e to the fact that =E2=80=9Ctarget=E2=80=9D is now actually set and the package buil= d thus behaves differently? [PATCH 8/9] removes a reference to =E2=80=9Cfirware=E2=80=9D; this answers = my question to patch 4/9, but perhaps other such references remain? --=20 Ricardo