unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: Sharlatan Hellseher <sharlatanus@gmail.com>,
	60793@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>
Cc: Sharlatan Hellseher <sharlatanus@gmail.com>
Subject: [bug#60793] [PATCH 1/3] gnu: Add julia-cfitsio-jll.
Date: Mon, 30 Jan 2023 11:59:23 +0100	[thread overview]
Message-ID: <875ycomgok.fsf@gmail.com> (raw)
In-Reply-To: <20230129222925.11361-1-sharlatanus@gmail.com>

Hi,

On dim., 29 janv. 2023 at 22:29, Sharlatan Hellseher <sharlatanus@gmail.com> wrote:

> +      #:phases
> +      (modify-phases %standard-phases
> +          (add-after 'link-depot 'override-binary-path
> +            (lambda* (#:key inputs #:allow-other-keys)
> +              (map
> +               (lambda (wrapper)
> +                 (substitute* wrapper
> +                   (("using LibCURL_jll") "") ; We use Guix's cfitsio
> +                   (("using Zlib_jll") "") ; Not require to upnpack not donwloaded archvie.
                                                              --^
                                                            Typo

Typo: s/upnpack/unpack

> +    (synopsis "cfitsio library wrappers")

--8<---------------cut here---------------start------------->8---
gnu/packages/julia-jll.scm:188:14: julia-cfitsio-jll@4.0.0+0: synopsis should start with an upper-case letter or digit
--8<---------------cut here---------------end--------------->8---

Maybe,

    (synopsis "CFITSIO library wrappers")

because it seems the official name:
<https://heasarc.gsfc.nasa.gov/fitsio/>.  All capital.


Cheers,
simon




  parent reply	other threads:[~2023-01-30 11:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 22:16 [bug#60793] [PATCH] gnu: Add julia-cfitsio-jll Sharlatan Hellseher
2023-01-16 17:08 ` Simon Tournier
2023-01-16 20:36   ` Sharlatan Hellseher
2023-01-17  8:03     ` Simon Tournier
2023-01-29 22:26       ` Sharlatan Hellseher
2023-01-30 11:11         ` Simon Tournier
2023-01-29 22:29 ` [bug#60793] [PATCH 1/3] " Sharlatan Hellseher
2023-01-29 22:29   ` [bug#60793] [PATCH 2/3] gnu: Add julia-cfitsio Sharlatan Hellseher
2023-01-29 22:29   ` [bug#60793] [PATCH 3/3] gnu: Add julia-fitsio Sharlatan Hellseher
2023-01-30 10:59   ` Simon Tournier [this message]
2023-01-30 11:12 ` [bug#60793] [PATCH v2 1/3] gnu: Add julia-cfitsio-jll Simon Tournier
2023-01-30 11:12   ` [bug#60793] [PATCH v2 2/3] gnu: Add julia-cfitsio Simon Tournier
2023-01-30 11:12   ` [bug#60793] [PATCH v2 3/3] gnu: Add julia-fitsio Simon Tournier
2023-02-08 10:13   ` bug#60793: [PATCH v2 1/3] gnu: Add julia-cfitsio-jll Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ycomgok.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=60793@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).