From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mDOHAkx24mOc9wAAbAwnHQ (envelope-from ) for ; Tue, 07 Feb 2023 17:03:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sENaAkx24mM8fAEAauVa8A (envelope-from ) for ; Tue, 07 Feb 2023 17:03:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 797F23D3FB for ; Tue, 7 Feb 2023 17:03:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPQQy-0003N0-FV; Tue, 07 Feb 2023 11:03:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPQQx-0003MH-Bz for guix-patches@gnu.org; Tue, 07 Feb 2023 11:03:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPQQx-0002Hk-1x for guix-patches@gnu.org; Tue, 07 Feb 2023 11:03:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPQQw-0000G3-Th for guix-patches@gnu.org; Tue, 07 Feb 2023 11:03:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60899] [PATCH 00/25] gnu: golang: Add gopls Resent-From: Katherine Cox-Buday Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Feb 2023 16:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60899 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: "\(" , 60899@debbugs.gnu.org, 60899-done@debbugs.gnu.org Received: via spool by 60899-done@debbugs.gnu.org id=D60899.1675785742931 (code D ref 60899); Tue, 07 Feb 2023 16:03:02 +0000 Received: (at 60899-done) by debbugs.gnu.org; 7 Feb 2023 16:02:22 +0000 Received: from localhost ([127.0.0.1]:53838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPQQH-0000Es-Jc for submit@debbugs.gnu.org; Tue, 07 Feb 2023 11:02:22 -0500 Received: from mail-il1-f182.google.com ([209.85.166.182]:37795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPQQF-0000Ea-4K; Tue, 07 Feb 2023 11:02:19 -0500 Received: by mail-il1-f182.google.com with SMTP id o13so2364502ilt.4; Tue, 07 Feb 2023 08:02:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=sb7F1hLRqML2iE/6vbvzM+JvzaarSoxOu+yN56vZPwM=; b=D5DWaAXxt9x5JH/jgyUtGD9fjJr8MtLl+fPnqtT8Ag3fkNWRziaBInq4/pdLsr1NlT xhHgjWuv/xe14u+ec5+GHTayc11Vhee/5xX+3TCaOq9NbTpNUzOklc+lXLHVds+XeIa+ tYIeZ64jymMWlXIRsWZO3KLQXkp0BAKUNyO7RvkrsY2Bn/tJYdwDL+NHPSzGB0gJ7wtJ 22lRQpFIojgBv3cCq1zOVOHHcre4qtOe2NBx5R5nluihlIdK1DevuayAm8zmDz3CiFKG FHIF6pInilSO2xu0IGzzq/kst1O46ewlq8JMSuXrLxB5+0ShYhqJ61ssJt6AIrAzgSa+ 0vKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sb7F1hLRqML2iE/6vbvzM+JvzaarSoxOu+yN56vZPwM=; b=B5T7m675TOZ66+zmdli+QM5+PMRWWGGnrpO7MTji2FRb65mJ3dm+zNDlzrhqRDI62s qobaqq4+4DjY7B91eU6yRgZhKf0Se7PYUdTowDcCZJIotwV915MBC53LYV49kmpj0QuM 5lYkzPdoK+tk/zX6DAKVJP3SMaEClo9tJKhvs7WQ9tP0V/8PuX00JhOH+CZR6UY4kwTH zk11UN4RwN8A6UGQFZDPmi5p1vvB9vvgjZfJHvFWT0PWRKjWWAyBeXjXrhbO0BOAqiAY PNPPGrDdG7zMgBrp22G90NtL5W6EdaG1VGjbkD6QI0qt/QSiflJGkPSTQpn7hQ0LIfyy K3kw== X-Gm-Message-State: AO0yUKVPqAJsporFQjZ+duOup064QUb92ODc8qJVW/szU9oMuUupqaTm TBROO+wTrw+SwdBVO76ZkK0Mg/VP1getHg== X-Google-Smtp-Source: AK7set+wR3zPTg7pdKpP3Qqvwrk5fEqtsWMrXVEl9RkFqae+rfdAoc6kHrnk7C6/GyK5EVAqGQScOA== X-Received: by 2002:a05:6e02:1947:b0:313:b8b6:a05d with SMTP id x7-20020a056e02194700b00313b8b6a05dmr4590651ilu.2.1675785733649; Tue, 07 Feb 2023 08:02:13 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id o3-20020a02cc23000000b0039d724c2416sm4372223jap.134.2023.02.07.08.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 08:02:13 -0800 (PST) From: Katherine Cox-Buday References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <87cz6mcrnq.fsf@cbaines.net> <878rh9didm.fsf@cbaines.net> Date: Tue, 07 Feb 2023 09:02:12 -0700 In-Reply-To: <878rh9didm.fsf@cbaines.net> (Christopher Baines's message of "Tue, 07 Feb 2023 08:42:51 +0100") Message-ID: <875ycdzcor.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=D5DWaAXx; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675785803; a=rsa-sha256; cv=none; b=mzzvDO5yv7zxT3vt6HKIfDzUeGJDheORoPP9sSZO/wk6NnPDwhzQ9tN/qNkQ16HC8yv6iJ GmPao4wJlbp3m7zP677u5a7ZzbjtvcY7wR9tcw+iUdCmd+XJrgWRyasLSOeaO5wwyZ9yap SS/QOuVye8UN/8J5hDFgpEdAv2KAXElxeWSl95udbE7m9OhI8scrjv0L8vn0fcA8D1Ym4W G4hWSp8RC+7HEtiqNDK1OdasdBIxCv84NcFWOWnvKjAeQtN0XqmmPklkijh4alS93jkuLE qOzBKer6hWJrJ8oA90oyPqoVE0TxijITVgmB968ME/mIWnBbHnm4Z6c0Giy5LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675785803; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=sb7F1hLRqML2iE/6vbvzM+JvzaarSoxOu+yN56vZPwM=; b=nJLd34XjnmU74sDhfWL2d671nE1TSHWyC0S0DXmeS72LC6fcNYrHtnR8hUE+0orDhLeEy4 FIBMABk/cqjHcRfA1w6G77C4z+/WF1RRGZWmg5fbMhVhYrNWmjv9cbbCcv4YKMQlFiD0SA hGmr4Gg6yeBbszzkIuL6sazd+ddVQbx18wqXvJMqR1DVjKjFq0meHgQJ/v939YxHEf7NUA x0ln7OHEwWaNbve0DS/FtNf6w0f0I5uXw8gwhZkkZzUf9yvxaFkvpzP+WAElKI+tvBmvQ7 YeNPfRsbOnpBCYAOP5NfVyid4jtyXSUFnsU+/G3/1+viDH0SzZkqyY8na4VYVg== X-Migadu-Queue-Id: 797F23D3FB X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=D5DWaAXx; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: -2.49 X-Spam-Score: -2.49 X-TUID: ihJeXfyNUORU Christopher Baines writes: > "(" writes: > >> [[PGP Signed Part:Undecided]] >> On Mon Feb 6, 2023 at 11:14 PM GMT, Christopher Baines wrote: >>> I've made a few tweaks and pushed this to master as >>> f3ab5888a0bc6446104ddbba41a413a86eb298e2. >> >> Nooo, my review was too slow :P > > I think reviewing changes/sending feedback after things have been merged > is fine (and important). If more people get involved in reviewing > things, this is probably something that'll happen more, so I think for > now it's good to embrace it. > > Hopefully we can continue the discussion around these changes and > perhaps further improve things with some additional patches. > > Chris I responded to Chris's original message, but: +1 to what Chris says. I'm still going to look at your feedback, paren, and maybe send some more patches. Personally, I prefer always moving forward, so long as it doesn't break anything. Thank you very much for the reviews! -- Katherine