From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id gBb4ObObPmSLvAAASxT56A (envelope-from ) for ; Tue, 18 Apr 2023 15:31:32 +0200 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gEb2OLObPmTo1AAAG6o9tA (envelope-from ) for ; Tue, 18 Apr 2023 15:31:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 86A11317C2 for ; Tue, 18 Apr 2023 15:31:31 +0200 (CEST) Authentication-Results: aspmx2.migadu.com; dkim=none; spf=pass (aspmx2.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681824691; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=i9nIZsmoMdRAhUX9PahBf4SQY8OpHTpR13y60s843vU=; b=a5Z/4/pu0xOmkSuV6eVkLPqx1+D5pAnaOTBNaoOWm5Frc/xSXkRtJ3Yfh0KOEc9h8RLgo4 KhAj2jZVl3myjI88sLeU8SCn1wref0KHrH7QGSyFK7W5C4mRak5C+STtu9V3pjoJSCyVXH QVOZxOGlTGeAk0FgSXRM6tmxdhrgujCKCEt3nYeavMHA1CwTWPl6Eqc6pF/iqzRv+r/TWB ifwck3VorRKcuokXYx96qHpJUW7hK/cDs/Yb2fWQHNI7QxKGQv1FX+4o+C042aWXclhCKn mRV+uXWuy1JL7Vv4XbKVrkkSOgfjh3W2Vvu5E8FmwOiw5fXQW7n7WmvtJeURNg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681824691; a=rsa-sha256; cv=none; b=PJzFSPMhEY4UIXs6+JgbJwvkB4IisgIDKlcYlwPAmvQimypfqQObc/iiVXTqadmd878Ey9 Rri2lR2q3pPVRHZcV1NuoSMpVRLQFksX0n2DF7rC7WF07iht7pGeUJnJM8o8NvQ/VA7ZXB sII7z9xYiTudz+tEc+lCLUOV8wgR0bMUeOLgdpDH+xnzfiJMU9TfwQO7QzXWUW+YsCzhqs JmNBv9oZ4+uN+5X7vDoXjmhSw3ORNvde+BBIbL86g4VCPmmNyPd5/Ytl0HGHyWfIPoK6wN 391NbTUoc1YI7r1h13mJyFYhMJIDcHGXeXQB5yUCj1C5Kt+nGuPXO2nny3Bq0Q== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=none; spf=pass (aspmx2.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1polQO-0004LI-Ut; Tue, 18 Apr 2023 09:31:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1polQE-0004L2-MC for guix-patches@gnu.org; Tue, 18 Apr 2023 09:31:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1polQE-0000ti-2I for guix-patches@gnu.org; Tue, 18 Apr 2023 09:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1polQD-0003Vq-Nd for guix-patches@gnu.org; Tue, 18 Apr 2023 09:31:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62921] [PATCH] gnu: emacs-gerbil-mode: Add emacs-gerbil-mode. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Apr 2023 13:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62921 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Juliana Sims Cc: 62921@debbugs.gnu.org, liliana.prikler@gmail.com Received: via spool by 62921-submit@debbugs.gnu.org id=B62921.168182460813354 (code B ref 62921); Tue, 18 Apr 2023 13:31:01 +0000 Received: (at 62921) by debbugs.gnu.org; 18 Apr 2023 13:30:08 +0000 Received: from localhost ([127.0.0.1]:58164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1polPL-0003TI-Qt for submit@debbugs.gnu.org; Tue, 18 Apr 2023 09:30:08 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:36097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1polPK-0003SU-F5 for 62921@debbugs.gnu.org; Tue, 18 Apr 2023 09:30:07 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 43460100004; Tue, 18 Apr 2023 13:29:58 +0000 (UTC) From: Nicolas Goaziou References: <20230418033754.11120-1-juli@incana.org> Date: Tue, 18 Apr 2023 15:29:52 +0200 In-Reply-To: <20230418033754.11120-1-juli@incana.org> (Juliana Sims's message of "Mon, 17 Apr 2023 23:37:54 -0400") Message-ID: <875y9tl3n3.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.82 X-Spam-Score: -2.82 X-Migadu-Queue-Id: 86A11317C2 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZUB6xiUB7zhv Hello, Juliana Sims writes: > * gnu/packages/emacs-xyz.scm (emacs-gerbil-mode): Add > emacs-gerbil-mode. Thank you. Some comments follow. > +(define-public emacs-gerbil-mode > + (package > + (name "emacs-gerbil-mode") > + (version "0.17.0") Note: according to "gerbil-mode.el", the version is actually "1.0". However, I understand that the file is "tagged" as 0.17.0 as a part of the whole Gerbil package. Maybe the whole package should inherit from `gerbil' package so version, source, home-page and license are already set in the parent. WDYT? > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/vyzo/gerbil") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0c0nspm659ybgmqlppdv7sxzll4hwkvcp9qmcsip6d0kz0p8r9c3")))) > + (build-system emacs-build-system) > + (arguments > + (list #:phases > + #~(modify-phases %standard-phases > + (add-before 'install 'change-directory > + (lambda _ > + (chdir "etc")))))) > + (home-page "https://github.com/vyzo/gervil") Typo: gervil -> gerbil > + (synopsis "Emacs major-mode for editing Gerbil code") > + (description > + "Gerbil mode provides font-lock, indentation, navigation, and REPL for > +Gerbil code within Emacs.") > + (license (list license:lgpl2.1 license:asl2.0)))) First license is lgpl2.1+. You should also mention in a comment that one can choose either. Regards, -- Nicolas Goaziou