From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Juliana Sims <juli@incana.org>
Cc: 62921@debbugs.gnu.org, liliana.prikler@gmail.com
Subject: [bug#62921] [PATCH] gnu: emacs-gerbil-mode: Add emacs-gerbil-mode.
Date: Tue, 18 Apr 2023 15:29:52 +0200 [thread overview]
Message-ID: <875y9tl3n3.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20230418033754.11120-1-juli@incana.org> (Juliana Sims's message of "Mon, 17 Apr 2023 23:37:54 -0400")
Hello,
Juliana Sims <juli@incana.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-gerbil-mode): Add
> emacs-gerbil-mode.
Thank you. Some comments follow.
> +(define-public emacs-gerbil-mode
> + (package
> + (name "emacs-gerbil-mode")
> + (version "0.17.0")
Note: according to "gerbil-mode.el", the version is actually "1.0".
However, I understand that the file is "tagged" as 0.17.0 as a part of
the whole Gerbil package.
Maybe the whole package should inherit from `gerbil' package so version,
source, home-page and license are already set in the parent. WDYT?
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/vyzo/gerbil")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0c0nspm659ybgmqlppdv7sxzll4hwkvcp9qmcsip6d0kz0p8r9c3"))))
> + (build-system emacs-build-system)
> + (arguments
> + (list #:phases
> + #~(modify-phases %standard-phases
> + (add-before 'install 'change-directory
> + (lambda _
> + (chdir "etc"))))))
> + (home-page "https://github.com/vyzo/gervil")
Typo: gervil -> gerbil
> + (synopsis "Emacs major-mode for editing Gerbil code")
> + (description
> + "Gerbil mode provides font-lock, indentation, navigation, and REPL for
> +Gerbil code within Emacs.")
> + (license (list license:lgpl2.1 license:asl2.0))))
First license is lgpl2.1+. You should also mention in a comment that one
can choose either.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-04-18 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 3:37 [bug#62921] [PATCH] gnu: emacs-gerbil-mode: Add emacs-gerbil-mode Juliana Sims
2023-04-18 13:29 ` Nicolas Goaziou [this message]
2023-04-18 17:05 ` [bug#62921] [PATCH v2] " Juliana Sims
2023-04-21 15:02 ` bug#62921: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y9tl3n3.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=62921@debbugs.gnu.org \
--cc=juli@incana.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).