unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Carlo Zancanaro <carlo@zancanaro.id.au>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 49181@debbugs.gnu.org
Subject: [bug#49181] Fix missing phases in Emacs builds
Date: Sat, 20 May 2023 23:13:12 +1000	[thread overview]
Message-ID: <875y8n2lb3.fsf@zancanaro.id.au> (raw)
In-Reply-To: <87cz4s47wj.fsf_-_@gmail.com>

Hi Maxim,

On Tue, Mar 28 2023, Maxim Cournoyer wrote:
> Have you seen the good comments from Sarah up thread? Perhaps 
> you could send a rebased v2 integrating them.

I've sent an updated patch with the fix that Sarah mentioned. I 
also added "core updates" to the PATCH bit, because I imagine 
Sarah is right that this would trigger a bunch of rebuilds.

I'm not sure that these changes warranted a two year wait on this 
patch, but I still think the patch is worth merging.

Carlo




  reply	other threads:[~2023-05-20 14:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23  6:45 [bug#49181] Fix missing phases in Emacs builds Carlo Zancanaro
2021-06-23  7:25 ` [bug#49181] [PATCH 0/1] modify-phases: error when encountering missing phase (was: Fix missing phases in Emacs builds) Leo Prikler
2021-06-23  7:25   ` [bug#49181] [PATCH 1/1] guix: Make modify-phases error when adding before/after a missing phase Leo Prikler
2021-07-23 21:32     ` [bug#49181] Fix missing phases in Emacs builds Sarah Morgensen
2021-11-02 22:58     ` [bug#49181] [PATCH 1/1] guix: Make modify-phases error when adding before/after a missing phase Carlo Zancanaro
2023-03-29  2:18       ` [bug#49181] Fix missing phases in Emacs builds Maxim Cournoyer
2023-05-20 13:13         ` Carlo Zancanaro [this message]
2023-05-20 13:05 ` [bug#49181] [PATCH core-updates v2] guix: Make modify-phases error when adding before/after a missing phase Carlo Zancanaro
2023-10-10  0:50   ` Carlo Zancanaro
2023-10-10  3:37   ` bug#49181: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y8n2lb3.fsf@zancanaro.id.au \
    --to=carlo@zancanaro.id.au \
    --cc=49181@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).