From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wCxkCaA9b2SPbwEASxT56A (envelope-from ) for ; Thu, 25 May 2023 12:51:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mLZiCKA9b2QB4wAAG6o9tA (envelope-from ) for ; Thu, 25 May 2023 12:51:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BCCDB12E95 for ; Thu, 25 May 2023 12:51:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q28Yh-0002M4-Fy; Thu, 25 May 2023 06:51:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q28Yf-0002Ll-W9 for guix-patches@gnu.org; Thu, 25 May 2023 06:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q28Yf-0006hV-OF for guix-patches@gnu.org; Thu, 25 May 2023 06:51:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q28Yf-0007mH-KM for guix-patches@gnu.org; Thu, 25 May 2023 06:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63691] [PATCH vREVISION] Add emacs-prism package Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 May 2023 10:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63691 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maciej Kalandyk Cc: 63691@debbugs.gnu.org Received: via spool by 63691-submit@debbugs.gnu.org id=B63691.168501180129748 (code B ref 63691); Thu, 25 May 2023 10:51:01 +0000 Received: (at 63691) by debbugs.gnu.org; 25 May 2023 10:50:01 +0000 Received: from localhost ([127.0.0.1]:46090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q28Xh-0007jZ-7Q for submit@debbugs.gnu.org; Thu, 25 May 2023 06:50:01 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:44569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q28Xf-0007jM-Lu for 63691@debbugs.gnu.org; Thu, 25 May 2023 06:50:00 -0400 X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id D42BFE000B; Thu, 25 May 2023 10:49:52 +0000 (UTC) From: Nicolas Goaziou References: Date: Thu, 25 May 2023 12:49:46 +0200 In-Reply-To: (Maciej Kalandyk's message of "Thu, 25 May 2023 04:15:40 +0200") Message-ID: <875y8gheid.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685011872; a=rsa-sha256; cv=none; b=exonWyK1zYsBKFPEtwhqvdMkt+rBugUm1OrRl3arn7KCO8Gdevw8NsbqHdJfyXRaF2M0Ov y+lFen9/iMu8HMIdL5FuYc2mZVDWqiRvMIh7mksgl1PPOvTzUAi825/1nMZng3Prn3uFHb KD30YSOJDoAagy4kCMbFLyToCvzdAqsO+zNKnXumxVGyCSpzXBh2rRoSzz1+CJyIWknrwc E6IQL0MBZXnNzHyXpq5osWpuHaF+mShBszEbcEfYAUUS76MyZkrVnCnsPS8CghTCY9OQXU SZooyi3jN+l/O40I3yLlmf1WbCslj3MawsTiTad5LCXCZozWnh3UEsbeK16oFA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685011871; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=p7uz3v0hCBVXoyeTuab7jdSUZ5d/57JhshI/0zOndpg=; b=e3Ri+RFe/aM8aOwdIrO+j+tjjk0AYBffOLymIBkJPl8neau7x36CqRS4n5+KroC1YODOO1 eGXHklnktER2XeJuS9YdWfQqci7uW50+YLPz4ZW1IsAgXxtTiNYNfp0f9vbpitk4gGOA2I 2o2rMnC3bFn86wPH44jmGB6k3GL8YeCZEgwYkk6BdrGN8J36R1ilxi+O2c5io/N8Hc8KiT Krh2DX0GVvsZD5FMaYJWIcW5tQPXwrbSybUhmTP7CIn5Kc2a8ZvumpPVXoz4nZorbcn5xg dUBI2/BYfYdMEoR2v92Frz7r2jB8JRWSJS5QjVmNyJxqfdG7/+rh2drBhpUVvw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.27 X-Spam-Score: -3.27 X-Migadu-Queue-Id: BCCDB12E95 X-TUID: 7s2lklbw+B8I Hello, Maciej Kalandyk writes: > +(define-public emacs-prism Thank you. You need to add a proper commit message with your patch. For a new variable, it is pretty much normalized: gnu: Add emacs-prism. * gnu/packages/emacs-xyz.scm (emacs-prism): New variable. > + (package > + (name "emacs-prism") > + (version "0.3.1") Version 0.3.2 was released yesterday, you may want to provide it instead. > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/alphapapa/prism.el.git") There's a habit of dropping ".git" suffix in URL, so the above should be: (url "https://github.com/alphapapa/prism.el") > + (commit version))) > + (sha256 > + (base32 > + "1750s161ck83lcl36rm2jbkssbgpa9hfx1gbv2r582381q1p4kwp")))) > + (build-system emacs-build-system) > + (inputs (list emacs-dash)) > + (home-page "https://github.com/alphapapa/prism.el") > + (synopsis > + "Disperses lisp forms (and other languages) into a spectrum of color by depth") I suggest: Disperse Lisp forms... > + (description > + "prism is an \"rainbow-blocks\" like mode for Emacs, but it > respects existing non-color face properties, and allows flexible > configuration of faces and colors.") I suggest: Prism is a Rainbow Blocks-like mode for Emacs. It preserves non-color face properties and allows configuration of faces and colors. Also mind keeping line lengths below 80 columns. Could you send an updated patch? (note it should be -v3 in the git command line)? Regards, -- Nicolas Goaziou