unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: "Jakub Kądziołka" <kuba@kadziolka.net>, 42752@debbugs.gnu.org
Subject: [bug#42752] [PATCH core-updates] gnu: bash: Make completions work in non-login shells.
Date: Sat, 21 Oct 2023 15:24:02 -0400	[thread overview]
Message-ID: <875y2zeq3x.fsf_-_@gmail.com> (raw)
In-Reply-To: <874kp9y3ka.fsf@gnu.org> (Mathieu Othacehe's message of "Tue, 11 Aug 2020 10:44:37 +0200")

Hi,

Mathieu Othacehe <othacehe@gnu.org> writes:

> Hello,
>
>> Oh! It seems I overwrote it with my own .bashrc when I migrated my
>> dotfiles. I still think this patch is a good idea - I think we should
>> make /etc/skel/.bashrc contain only nice-to-have defaults, such as
>> changing the prompt based on $GUIX_ENVIRONMENT, and move the essential
>> things to /etc/bashrc. That way, overwriting the .bashrc won't break
>> anything important.
>>
>> I guess I should follow this patch up with an adjustment to
>> /etc/skel/.bashrc, removing the 'source /etc/bashrc' line?
>
> That would make sense. Maybe you could replace the sourcing by a comment
> explaining how bash behaviour is altered to source /etc/bashrc for
> interactive, non-login shell.

I somewhat weary of the undefined behavior this could have on foreign
distributions?

I'll close this, but feel free to continue discussing it here.

-- 
Thanks,
Maxim




      reply	other threads:[~2023-10-21 19:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07 22:14 [bug#42752] [PATCH core-updates] gnu: bash: Make completions work in non-login shells Jakub Kądziołka
2020-08-10  9:25 ` Mathieu Othacehe
2020-08-10 14:41   ` Jakub Kądziołka
2020-08-11  8:44     ` Mathieu Othacehe
2023-10-21 19:24       ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y2zeq3x.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=42752@debbugs.gnu.org \
    --cc=kuba@kadziolka.net \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).